Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial value of align-content and justify-content #15594

Merged
merged 2 commits into from Feb 17, 2017
Merged

Fix initial value of align-content and justify-content #15594

merged 2 commits into from Feb 17, 2017

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented Feb 16, 2017 •
edited by larsbergstrom

This fixes a trivial mistake in #15533, caused by me misreading the spec. r? @Manishearth

This change is Reviewable
@mbrubeck
Fix initial value of align-content and justify-content
Loading status checks…
4c27304
@highfive
Copy link

highfive commented Feb 16, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/position.mako.rs, components/style/values/specified/align.rs
  • @emilio: components/style/properties/longhand/position.mako.rs, components/style/values/specified/align.rs
@highfive
Copy link

highfive commented Feb 16, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@Manishearth
Copy link
Member

Manishearth commented Feb 16, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2017

📌 Commit 4c27304 has been approved by Manishearth
@Manishearth
Copy link
Member

Manishearth commented Feb 16, 2017

@bors-servo r-

wait, spec says that the initial values are stretch and flex-start?
@mbrubeck
Copy link
Contributor Author

mbrubeck commented Feb 16, 2017

https://drafts.csswg.org/css-align/#propdef-align-content

Name: align-content, justify-content
Initial: normal
@Manishearth
Copy link
Member

Manishearth commented Feb 16, 2017

Ah. Please update the spec links, then 😄 . r=me
@mbrubeck
Update spec links for align-content and justify-content
Loading status checks…
33338ca
@mbrubeck
Copy link
Contributor Author

mbrubeck commented Feb 16, 2017

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2017

📌 Commit 33338ca has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Feb 17, 2017

⌛ Testing commit 33338ca with merge 3fa9ce1...
bors-servo added a commit that referenced this pull request Feb 17, 2017
@bors-servo
Auto merge of #15594 - mbrubeck:align-content-fix, r=Manishearth
Loading status checks…
3fa9ce1 
Fix initial value of align-content and justify-content

This fixes a trivial mistake in #15533, caused by me misreading the spec. r? @Manishearth

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15594)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 17, 2017

💔 Test failed - linux-rel-css
@mbrubeck
Copy link
Contributor Author

mbrubeck commented Feb 17, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 17, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev are reusable. Rebuilding only linux-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 17, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: Manishearth
Pushing 3fa9ce1 to master...
@bors-servo bors-servo merged commit 33338ca into servo:master Feb 17, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@mbrubeck
Copy link
Contributor Author

mbrubeck commented Feb 17, 2017

cc #15583
@mbrubeck mbrubeck deleted the mbrubeck:align-content-fix branch May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@mbrubeck @highfive @Manishearth @bors-servo
You can’t perform that action at this time.