Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWrap CGFont in NativeFontHandle #15615
Closed
Conversation
highfive
commented
Feb 17, 2017
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @KiChjang (or someone else) soon. |
highfive
commented
Feb 17, 2017
|
|
This was referenced Feb 17, 2017
|
You'll also need to update webrender to the version where it contains servo/webrender#896. |
|
|
|
Closing for inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jbg commentedFeb 17, 2017
•
edited
Pull request servo/webrender#896 makes
NativeFontHandlea wrapper type (a newtype struct). This pull request wraps the cachedCGFontin this newtype struct before passing it to webrender../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is