Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WR (inset box shadow fix, border-image support). #15681

Merged
merged 1 commit into from Feb 22, 2017
Merged

Update WR (inset box shadow fix, border-image support). #15681

merged 1 commit into from Feb 22, 2017

Conversation

@glennw
Copy link
Member

glennw commented Feb 22, 2017 •
edited by larsbergstrom

I have a follow up PR for Servo that uses the new border-image
APIs, but I'll land that separately, so that we don't delay
landing the WR update itself.

This change is Reviewable
@gw3583
Update WR (inset box shadow fix, border-image support).
Loading status checks…
c4a972a 
I have a follow up PR for Servo that uses the new border-image
APIs, but I'll land that separately, so that we don't delay
landing the WR update itself.
@highfive
Copy link

highfive commented Feb 22, 2017

Heads up! This PR modifies the following files:

  • @emilio: components/layout/webrender_helpers.rs
@highfive
Copy link

highfive commented Feb 22, 2017

warning Warning warning

  • These commits modify layout code, but no tests are modified. Please consider adding a test!
@wafflespeanut
Copy link
Member

wafflespeanut commented Feb 22, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 22, 2017

📌 Commit c4a972a has been approved by Wafflespeanut
@highfive highfive assigned wafflespeanut and unassigned jdm Feb 22, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Feb 22, 2017

⌛ Testing commit c4a972a with merge d661dcb...
bors-servo added a commit that referenced this pull request Feb 22, 2017
@bors-servo
Auto merge of #15681 - glennw:update-wr-box-shadows, r=Wafflespeanut
Loading status checks…
d661dcb 
Update WR (inset box shadow fix, border-image support).

I have a follow up PR for Servo that uses the new border-image
APIs, but I'll land that separately, so that we don't delay
landing the WR update itself.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15681)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 22, 2017

💔 Test failed - linux-rel-css
@wafflespeanut
Copy link
Member

wafflespeanut commented Feb 22, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 22, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev are reusable. Rebuilding only linux-rel-css...
@wafflespeanut
Copy link
Member

wafflespeanut commented Feb 22, 2017 •
edited

cc #15583 (I wonder why the filtering didn't work)
@bors-servo
Copy link
Contributor

bors-servo commented Feb 22, 2017

💔 Test failed - linux-rel-css
@wafflespeanut
Copy link
Member

wafflespeanut commented Feb 22, 2017

Okay #15583 again. Looks like our intermittents database needs to be updated.
@wafflespeanut
Copy link
Member

wafflespeanut commented Feb 22, 2017

(great, forgot to retry)

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 22, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev are reusable. Rebuilding only linux-rel-css...
@nox
Copy link
Member

nox commented Feb 22, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 22, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev are reusable. Rebuilding only linux-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 22, 2017

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Feb 22, 2017

@bors-servo: retry
#15583
The DB should actually be up to date now.
@bors-servo
Copy link
Contributor

bors-servo commented Feb 22, 2017

⌛ Testing commit c4a972a with merge fa5bc4a...
bors-servo added a commit that referenced this pull request Feb 22, 2017
@bors-servo
Auto merge of #15681 - glennw:update-wr-box-shadows, r=Wafflespeanut
Loading status checks…
fa5bc4a 
Update WR (inset box shadow fix, border-image support).

I have a follow up PR for Servo that uses the new border-image
APIs, but I'll land that separately, so that we don't delay
landing the WR update itself.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15681)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 22, 2017

💔 Test failed - windows-gnu-dev
@wafflespeanut
Copy link
Member

wafflespeanut commented Feb 22, 2017

@bors-servo retry

(something error something?)
@bors-servo
Copy link
Contributor

bors-servo commented Feb 22, 2017

⌛ Testing commit c4a972a with merge 800a1fd...
bors-servo added a commit that referenced this pull request Feb 22, 2017
@bors-servo
Auto merge of #15681 - glennw:update-wr-box-shadows, r=Wafflespeanut
Loading status checks…
800a1fd 
Update WR (inset box shadow fix, border-image support).

I have a follow up PR for Servo that uses the new border-image
APIs, but I'll land that separately, so that we don't delay
landing the WR update itself.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15681)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 22, 2017

💔 Test failed - linux-rel-css
@glennw
Copy link
Member Author

glennw commented Feb 22, 2017

I've timed the WPT tests with this update, and it seems to be around 3-4% slower, which might explain why it's triggering some of these intermittents. I'll investigate further today.
@glennw
Copy link
Member Author

glennw commented Feb 22, 2017

@bors-servo retry

  • It looks like 3 of the failures were expected intermittents, and one of them is a known intermittent occurring on a different test.
@bors-servo
Copy link
Contributor

bors-servo commented Feb 22, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev are reusable. Rebuilding only linux-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 22, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: Wafflespeanut
Pushing 800a1fd to master...
@bors-servo bors-servo merged commit c4a972a into servo:master Feb 22, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@glennw glennw deleted the glennw:update-wr-box-shadows branch Feb 23, 2017
@jonathandturner
Copy link

jonathandturner commented Feb 23, 2017

Just gave this a try. Looks like some of the recent fixes definitely are improving things (yay!), so we now aren't hanging on reddit/rust-lang/servo/HN.

I am seeing some font issues, but perhaps they're unrelated?

reddit_with_patch
This was referenced Feb 23, 2017
Closed
Closed
@ghost ghost mentioned this pull request Feb 24, 2017
Closed
11 of 11 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wafflespeanut wafflespeanut

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
@glennw @highfive @wafflespeanut @bors-servo @nox @jdm @jonathandturner @gw3583
You can’t perform that action at this time.