Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill missing property in keyframe #15683

Merged
merged 3 commits into from Feb 22, 2017

Conversation

@hiikezoe
Copy link
Contributor

hiikezoe commented Feb 22, 2017

This is a PR of https://bugzilla.mozilla.org/show_bug.cgi?id=1340961
All patches has been reviewed by @emilio.

Thanks!


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes

This change is Reviewable

Hiroyuki Ikezoe added 3 commits Feb 22, 2017
@Keyframes anim {
  from { transform: none; }
  to { opacity: 0; transform: none; }
}

In above case, we have to add opacity property and value in the 'from' keyframe.
… and final keyframes.

@Keyframes anim {
  from { opacity: 0; transform: none; }
  to { transform: none; }
}

In above case, we have to add opacity property and value in the 'to' keyframe.
@highfive

This comment has been minimized.

Copy link

highfive commented Feb 22, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/keyframes.rs, components/style/properties/properties.mako.rs, components/style/properties/helpers/animated_properties.mako.rs
  • @emilio: components/style/keyframes.rs, ports/geckolib/glue.rs, components/style/properties/properties.mako.rs, components/style/properties/helpers/animated_properties.mako.rs
@highfive

This comment has been minimized.

Copy link

highfive commented Feb 22, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@emilio

This comment has been minimized.

Copy link
Member

emilio commented Feb 22, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Feb 22, 2017

📌 Commit 396db28 has been approved by emilio

@highfive highfive assigned emilio and unassigned glennw Feb 22, 2017
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Feb 22, 2017

⌛️ Testing commit 396db28 with merge a6ce4b1...

bors-servo added a commit that referenced this pull request Feb 22, 2017
…emilio

Fill missing property in keyframe

<!-- Please describe your changes on the following line: -->
This is a PR of https://bugzilla.mozilla.org/show_bug.cgi?id=1340961
All patches has been reviewed by @emilio.

Thanks!

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15683)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Feb 22, 2017

💔 Test failed - windows-gnu-dev

@emilio

This comment has been minimized.

Copy link
Member

emilio commented Feb 22, 2017

@bors-servo retry

  • Windows builder failed to pull?
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Feb 22, 2017

⌛️ Testing commit 396db28 with merge 4f7e422...

bors-servo added a commit that referenced this pull request Feb 22, 2017
…emilio

Fill missing property in keyframe

<!-- Please describe your changes on the following line: -->
This is a PR of https://bugzilla.mozilla.org/show_bug.cgi?id=1340961
All patches has been reviewed by @emilio.

Thanks!

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15683)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Feb 22, 2017

@bors-servo bors-servo merged commit 396db28 into servo:master Feb 22, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@hiikezoe hiikezoe deleted the hiikezoe:fill-missing-property-in-keyframe branch Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.