Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for most of the border-image properties, pass to WR. #15697

Merged
merged 1 commit into from Feb 24, 2017
Merged

Add support for most of the border-image properties, pass to WR. #15697

merged 1 commit into from Feb 24, 2017

Conversation

@glennw
Copy link
Member

glennw commented Feb 23, 2017 •
edited by larsbergstrom

This adds support for:

  • border-image (images, not gradients yet)
  • border-image-source
  • border-image-slice
  • border-image-repeat (stretch + repeat only for now)

Remaining work:

  • Connect border-image-outset (WR supports this).
  • border-image-width

This change is Reviewable
@highfive
Copy link

highfive commented Feb 23, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/shorthand/border.mako.rs, components/style/properties/longhand/border.mako.rs
  • @KiChjang: components/script/dom/webidls/CSSStyleDeclaration.webidl
  • @fitzgen: components/script/dom/webidls/CSSStyleDeclaration.webidl
  • @emilio: components/layout/display_list_builder.rs, components/style/properties/shorthand/border.mako.rs, components/style/properties/longhand/border.mako.rs, components/layout/webrender_helpers.rs
@glennw
Copy link
Member Author

glennw commented Feb 23, 2017

r? @pcwalton for the display lists parts.
r? @jdm (or whoever is appropriate) for the webidl / mako bits).
@highfive highfive assigned pcwalton and unassigned mbrubeck Feb 23, 2017
@jdm
Copy link
Member

jdm commented Feb 23, 2017

If this could wait for #14962 to merge I would appreciate it.
@jdm
Copy link
Member

jdm commented Feb 23, 2017

Mako and WebIDL changes look fine.
@glennw
Copy link
Member Author

glennw commented Feb 23, 2017

@jdm Yup, no problem waiting on that PR to land first :)
@jdm jdm added the S-fails-tidy label Feb 23, 2017
@glennw glennw force-pushed the glennw:border-image branch 2 times, most recently from 3e7644d to ad50d0e Feb 23, 2017
@glennw
Copy link
Member Author

glennw commented Feb 23, 2017

@pcwalton OK, #14962 has landed now, so this is ready for review. Also rebased and fixed the tidy error.
@gw3583
Add support for most of the border-image properties, pass to WR.
Loading status checks…
ffcb319 
This adds support for:
 * border-image (images, not gradients yet)
 * border-image-source
 * border-image-slice
 * border-image-repeat (stretch + repeat only for now)

Remaining work:
 * Connect border-image-outset (WR supports this).
 * border-image-width
@glennw glennw force-pushed the glennw:border-image branch from ad50d0e to ffcb319 Feb 23, 2017
@jdm jdm removed the S-fails-tidy label Feb 23, 2017
@pcwalton
Copy link
Contributor

pcwalton commented Feb 23, 2017

Looks good to me.
@glennw
Copy link
Member Author

glennw commented Feb 23, 2017

@bors-servo r=jdm,pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Feb 23, 2017

📌 Commit ffcb319 has been approved by jdm,pcwalton
@highfive highfive assigned jdm and unassigned pcwalton Feb 23, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Feb 23, 2017

⌛ Testing commit ffcb319 with merge 6c9e94b...
bors-servo added a commit that referenced this pull request Feb 23, 2017
@bors-servo
Auto merge of #15697 - glennw:border-image, r=jdm,pcwalton
Loading status checks…
6c9e94b 
Add support for most of the border-image properties, pass to WR.

This adds support for:
 * border-image (images, not gradients yet)
 * border-image-source
 * border-image-slice
 * border-image-repeat (stretch + repeat only for now)

Remaining work:
 * Connect border-image-outset (WR supports this).
 * border-image-width

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15697)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 23, 2017

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Feb 23, 2017

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 23, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 24, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: jdm,pcwalton
Pushing 6c9e94b to master...
@bors-servo bors-servo merged commit ffcb319 into servo:master Feb 24, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@glennw @highfive @jdm @pcwalton @bors-servo @mbrubeck @gw3583
You can’t perform that action at this time.