Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIntroduce CSSPixel as a replacement for ViewportPx and PagePx. #15700
Conversation
highfive
commented
Feb 23, 2017
|
Heads up! This PR modifies the following files:
|
highfive
commented
Feb 23, 2017
|
This change deserves some explanation. This PR is (sort of) a WIP. I want to get some feedback on whether The idea is to move pinch-zoom to be handled by WR as (almost) From what I can tell of the specifications and browser behaviour, Given the assumptions above, the Servo code now only needs to deal This PR doesn't break any existing functionality, since pinch zoom |
|
r? @mbrubeck |
|
Rebased and fixed tidy error. |
|
Style unit tests need updating. |
|
Thanks, updated the unit tests. |
| /// TODO(gw): Once WR supports pinch zoom, use a type directly from webrender_traits. | ||
| #[derive(Clone, Copy, Debug, PartialEq)] | ||
| #[cfg_attr(feature = "servo", derive(Deserialize, Serialize, HeapSizeOf))] | ||
| pub struct PinchZoomFactor(f32); |
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r+ Curious about the answer to the above question, but no changes required. |
|
|
Introduce CSSPixel as a replacement for ViewportPx and PagePx. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15700) <!-- Reviewable:end -->
|
|
glennw commentedFeb 23, 2017
•
edited by larsbergstrom
This change is