Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rustc-serialize from style and style_traits #15712

Merged
merged 1 commit into from Feb 24, 2017

Conversation

@nox
Copy link
Member

commented Feb 23, 2017

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Feb 23, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml, components/style/lib.rs, components/style/values/mod.rs, components/style/properties/longhand/inherited_table.mako.rs, components/style/properties/longhand/box.mako.rs
  • @emilio: components/style/Cargo.toml, components/style/lib.rs, components/style/values/mod.rs, components/style/properties/longhand/inherited_table.mako.rs, components/style/properties/longhand/box.mako.rs
@highfive

This comment has been minimized.

Copy link

commented Feb 23, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@metajack

This comment has been minimized.

Copy link
Contributor

commented Feb 23, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 23, 2017

📌 Commit 8a8ee28 has been approved by metajack

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 23, 2017

⌛️ Testing commit 8a8ee28 with merge 9908c70...

bors-servo added a commit that referenced this pull request Feb 23, 2017
Auto merge of #15712 - nox:rustc-serialize, r=metajack
Remove rustc-serialize from style and style_traits

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15712)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 23, 2017

💔 Test failed - linux-rel-css

@nox

This comment has been minimized.

Copy link
Member Author

commented Feb 23, 2017

This seems like an intermittent to me.

@nox

This comment has been minimized.

Copy link
Member Author

commented Feb 23, 2017

We'll see if mac-rel-css passes.

@nox

This comment has been minimized.

Copy link
Member Author

commented Feb 24, 2017

This passed on Mac, and I don't see why this patch would make this specific test crash anyway.

@bors-servo retry #15716

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 24, 2017

⌛️ Testing commit 8a8ee28 with merge f9f5578...

bors-servo added a commit that referenced this pull request Feb 24, 2017
Auto merge of #15712 - nox:rustc-serialize, r=metajack
Remove rustc-serialize from style and style_traits

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15712)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 24, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: metajack
Pushing f9f5578 to master...

@bors-servo bors-servo merged commit 8a8ee28 into servo:master Feb 24, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Feb 24, 2017
weilonge pushed a commit to fx-dev-playground/gecko that referenced this pull request Feb 24, 2017
JerryShih pushed a commit to JerryShih/gecko-dev that referenced this pull request Mar 1, 2017
Manishearth pushed a commit to Manishearth/gecko-dev that referenced this pull request Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.