Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake #[dom_struct] a proc_macro attribute #15715
Conversation
highfive
commented
Feb 24, 2017
|
Heads up! This PR modifies the following files:
|
|
@jdm Something tells me you are not going to like this... |
b6be5ea
to
4760004
|
|
|
Oh yes of course, this is going to get bitrot all the time. |
|
What's the error message if the import is missing? |
|
Can we use an absolute path like Or extern crate dom_struct as dom_struct_crate;
pub use dom_struct_crate::dom_struct; |
|
What's the error message if the import is missing?
That `dom_struct` is undefined, and it suggests to import it with its path printed.
|
|
Can we use an absolute path like `#[::dom_struct::dom_struct]`, so that no import is needed?
I guess yes but I would rather just keep the import.
|
|
@bors-servo r+ |
|
|
Make #[dom_struct] a proc_macro attribute The rustup is needed for rust-lang/rust#40039. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15715) <!-- Reviewable:end -->
|
|
nox commentedFeb 24, 2017
•
edited by larsbergstrom
The rustup is needed for rust-lang/rust#40039.
This change is