Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use servo's computed values to generate keyframes #15722

Merged
merged 4 commits into from Feb 24, 2017

Conversation

Projects
None yet
7 participants
@hiikezoe
Copy link
Contributor

commented Feb 24, 2017

This is the servo side changes for https://bugzilla.mozilla.org/show_bug.cgi?id=1338927 reviewed by @Manishearth.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because it's for stylo

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Feb 24, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko_bindings/bindings.rs, components/style/gecko_bindings/structs_debug.rs, components/style/build_gecko.rs, components/style/gecko_bindings/structs_release.rs
  • @emilio: components/style/gecko_bindings/bindings.rs, components/style/gecko_bindings/structs_debug.rs, ports/geckolib/glue.rs, components/style/build_gecko.rs, components/style/gecko_bindings/structs_release.rs
@highfive

This comment has been minimized.

Copy link

commented Feb 24, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@nox

This comment has been minimized.

Copy link
Member

commented Feb 24, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 24, 2017

📌 Commit bb3f2e9 has been approved by nox

@highfive highfive assigned nox and unassigned asajeffrey Feb 24, 2017

@wafflespeanut

This comment has been minimized.

Copy link
Member

commented Feb 24, 2017

@bors-servo r=Manishearth

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 24, 2017

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #15131
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 24, 2017

📌 Commit bb3f2e9 has been approved by Manishearth

@highfive highfive assigned Manishearth and unassigned nox Feb 24, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 24, 2017

⌛️ Testing commit bb3f2e9 with merge db3de6e...

bors-servo added a commit that referenced this pull request Feb 24, 2017

Auto merge of #15722 - hiikezoe:use-computed-values, r=Manishearth
Use servo's computed values to generater keyframes

<!-- Please describe your changes on the following line: -->
This is the servo side changes for https://bugzilla.mozilla.org/show_bug.cgi?id=1338927 reviewed by @Manishearth.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because it's for stylo

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15722)
<!-- Reviewable:end -->

@nox nox changed the title Use servo's computed values to generater keyframes Use servo's computed values to generate keyframes Feb 24, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 24, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: Manishearth
Pushing db3de6e to master...

@bors-servo bors-servo merged commit bb3f2e9 into servo:master Feb 24, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@bors-servo bors-servo referenced this pull request Feb 24, 2017

Closed

Don’t deduplicate declarations at parse time #15721

4 of 5 tasks complete

@hiikezoe hiikezoe deleted the hiikezoe:use-computed-values branch Feb 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.