Update cssparser to 0.11 #15735

SimonSapin · 2017-02-25T17:51:36Z

~~Depends on servo/rust-cssparser#122.~~

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #__ (github issue number if applicable).

There are tests for these changes OR
These changes do not require tests because _____

This change is

highfive · 2017-02-25T17:51:39Z

Heads up! This PR modifies the following files:

@bholley: components/style/values/specified/basic_shape.rs, components/style/properties/longhand/text.mako.rs, components/style/values/specified/length.rs, components/style/properties/properties.mako.rs, components/style/gecko/media_queries.rs, components/style/Cargo.toml, components/style/lib.rs, components/style/values/specified/image.rs, components/style/properties/longhand/font.mako.rs, components/style/servo/media_queries.rs, components/style/properties/longhand/effects.mako.rs, components/style/values/specified/mod.rs, components/style/properties/longhand/counters.mako.rs, components/style/properties/longhand/box.mako.rs, components/style/supports.rs, components/style/values/mod.rs, components/style/values/specified/align.rs, components/style/properties/helpers/animated_properties.mako.rs, components/style/values/specified/position.rs, components/style/properties/longhand/inherited_svg.mako.rs
@KiChjang: components/script/dom/csskeyframesrule.rs, components/script/lib.rs, components/script/Cargo.toml
@fitzgen: components/script/dom/csskeyframesrule.rs, components/script/lib.rs, components/script/Cargo.toml
@emilio: components/style/values/specified/basic_shape.rs, components/style/properties/longhand/text.mako.rs, components/style/values/specified/length.rs, components/style/properties/properties.mako.rs, components/style/gecko/media_queries.rs, components/style/Cargo.toml, components/style/lib.rs, components/style/values/specified/image.rs, components/style/properties/longhand/font.mako.rs, components/style/servo/media_queries.rs, components/style/properties/longhand/effects.mako.rs, components/style/values/specified/mod.rs, components/style/properties/longhand/counters.mako.rs, components/style/properties/longhand/box.mako.rs, components/style/supports.rs, components/style/values/mod.rs, components/style/values/specified/align.rs, components/style/properties/helpers/animated_properties.mako.rs, components/style/values/specified/position.rs, components/style/properties/longhand/inherited_svg.mako.rs

highfive · 2017-02-25T17:51:40Z

Warning

These commits modify style and script code, but no tests are modified. Please consider adding a test!

SimonSapin · 2017-02-25T17:51:41Z

@bors-servo try

bors-servo · 2017-02-25T17:51:44Z

⌛ Trying commit 84aa188 with merge 1c993ff...


        Auto merge of #15735 - servo:cssparserup, r=<try>

Update cssparser to 0.11  Depends on servo/rust-cssparser#122. ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____

SimonSapin · 2017-02-25T19:39:24Z

This is ready to land. r? @Manishearth

emilio · 2017-02-25T19:41:12Z

@bors-servo r+

bors-servo · 2017-02-25T19:41:13Z

📌 Commit eacc12d has been approved by emilio

bors-servo · 2017-02-25T19:54:08Z

⌛ Testing commit eacc12d with merge 11f362a...


        Auto merge of #15735 - servo:cssparserup, r=emilio

Update cssparser to 0.11  <s>Depends on https://github.com/servo/rust-cssparser/pull/122.</s> ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15735)

bors-servo · 2017-02-25T20:23:35Z

💔 Test failed - linux-rel-wpt

SimonSapin · 2017-02-25T21:42:27Z

{"status": "FAIL", "stack": null, "subtest": null, "action": "test_result", "test": "/_mozilla/css/overflow_wrap_a.html", "line": 64827, "message": "/_mozilla/css/overflow_wrap_a.html 57a783cf615a456badeb0f6c306887f9213b1ea0\n/_mozilla/css/overflow_wrap_ref.html 739aa7187d267c9ed72935ed31382631170de234\nTesting 57a783cf615a456badeb0f6c306887f9213b1ea0 == 739aa7187d267c9ed72935ed31382631170de234", "expected": "PASS"}

@bors-servo retry

bors-servo · 2017-02-25T21:42:31Z

⌛ Testing commit eacc12d with merge b7109ad...


        Auto merge of #15735 - servo:cssparserup, r=emilio

Update cssparser to 0.11  <s>Depends on https://github.com/servo/rust-cssparser/pull/122.</s> ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15735)

bors-servo · 2017-02-25T22:11:16Z

💔 Test failed - linux-rel-wpt

SimonSapin · 2017-02-25T22:50:06Z

@bors-servo retry

bors-servo · 2017-02-25T22:50:09Z

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-wpt1, windows-gnu-dev, windows-msvc-dev are reusable. Rebuilding only linux-rel-css, linux-rel-wpt, mac-rel-css, mac-rel-wpt2...

SimonSapin · 2017-02-25T22:50:19Z

#15738

bors-servo · 2017-02-25T23:19:17Z

💔 Test failed - linux-rel-wpt


        Define keyword values in ASCII lowercase

The match_ignore_ascii_case! macro does ASCII-case-insensitive matching. In cssparser verion 0.11, it will require its patterns to be already lower case.


        Replace 1-variant match_ignore_ascii_case! with expect_ident_matching


        Borrow input to match_ignore_ascii_case!

In cssparser version 0.11, this macro will stop implicitly borrowing its own input.


        Update to cssparser 0.11


        Use ascii_case_insensitive_phf_map! in PropertyId::parse

SimonSapin · 2017-02-26T10:19:29Z

I thought the failure above was intermittent because I couldn’t reproduce locally at first, but it looks like this is a real bug. I must have messed up my initial testing. The bug was in the "Use ascii_case_insensitive_phf_map! in PropertyId::parse" commit: I forgot to add property aliases to the map. The failing test is using the word-wrap property, an alias for overflow-wrap. With that fixed, the test passes on my machine.

@bors-servo r=emilio

bors-servo · 2017-02-26T10:19:30Z

📌 Commit 2f996e3 has been approved by emilio

bors-servo · 2017-02-26T10:19:33Z

⌛ Testing commit 2f996e3 with merge 94e563e...


        Auto merge of #15735 - servo:cssparserup, r=emilio

Update cssparser to 0.11  <s>Depends on https://github.com/servo/rust-cssparser/pull/122.</s> ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15735)

bors-servo · 2017-02-26T10:26:58Z

💡 This pull request was already approved, no need to approve it again.

This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.

bors-servo · 2017-02-26T10:26:59Z

📌 Commit 2f996e3 has been approved by emilio

bors-servo · 2017-02-26T11:06:14Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: emilio
Pushing 94e563e to master...

highfive assigned KiChjang Feb 25, 2017

highfive added the S-awaiting-review label Feb 25, 2017

SimonSapin force-pushed the cssparserup branch from afd5838 to eacc12d Feb 25, 2017

highfive assigned Manishearth and unassigned KiChjang Feb 25, 2017

highfive assigned emilio and unassigned Manishearth Feb 25, 2017

highfive added S-awaiting-merge and removed S-awaiting-review labels Feb 25, 2017

highfive added S-tests-failed and removed S-awaiting-merge labels Feb 25, 2017

highfive added S-awaiting-merge and removed S-tests-failed labels Feb 25, 2017

highfive added S-tests-failed and removed S-awaiting-merge labels Feb 25, 2017

highfive added the S-tests-failed label Feb 25, 2017

SimonSapin added 3 commits Feb 26, 2017

Define keyword values in ASCII lowercase

ba6d791

The match_ignore_ascii_case! macro does ASCII-case-insensitive matching. In cssparser verion 0.11, it will require its patterns to be already lower case.

Replace 1-variant match_ignore_ascii_case! with expect_ident_matching

4fa3e8e

Borrow input to match_ignore_ascii_case!

0f2d000

In cssparser version 0.11, this macro will stop implicitly borrowing its own input.

SimonSapin mentioned this pull request Feb 26, 2017

Intermittent failure in /_mozilla/css/overflow_wrap_a.html #15738

Closed

SimonSapin added 2 commits Feb 25, 2017

Update to cssparser 0.11

33ef6f7

Use ascii_case_insensitive_phf_map! in PropertyId::parse

Loading status checks…

2f996e3

SimonSapin force-pushed the cssparserup branch from eacc12d to 2f996e3 Feb 26, 2017

highfive added S-awaiting-review and removed S-tests-failed labels Feb 26, 2017

highfive added S-awaiting-merge and removed S-awaiting-review labels Feb 26, 2017

highfive removed the S-awaiting-merge label Feb 26, 2017

emilio deleted the cssparserup branch Feb 26, 2017

servo / servo

Update cssparser to 0.11 #15735

Update cssparser to 0.11 #15735

SimonSapin commented Feb 25, 2017 •

edited by larsbergstrom

highfive commented Feb 25, 2017

highfive commented Feb 25, 2017

SimonSapin commented Feb 25, 2017

bors-servo commented Feb 25, 2017

SimonSapin commented Feb 25, 2017

emilio commented Feb 25, 2017

bors-servo commented Feb 25, 2017

bors-servo commented Feb 25, 2017

bors-servo commented Feb 25, 2017

SimonSapin commented Feb 25, 2017

bors-servo commented Feb 25, 2017

bors-servo commented Feb 25, 2017

SimonSapin commented Feb 25, 2017

bors-servo commented Feb 25, 2017

SimonSapin commented Feb 25, 2017

bors-servo commented Feb 25, 2017

SimonSapin commented Feb 26, 2017 •

edited

bors-servo commented Feb 26, 2017

bors-servo commented Feb 26, 2017

bors-servo commented Feb 26, 2017

bors-servo commented Feb 26, 2017

bors-servo commented Feb 26, 2017

servo / servo

Join GitHub today

Update cssparser to 0.11 #15735

Update cssparser to 0.11 #15735

Conversation

SimonSapin commented Feb 25, 2017 • edited by larsbergstrom

highfive commented Feb 25, 2017

highfive commented Feb 25, 2017

SimonSapin commented Feb 25, 2017

bors-servo commented Feb 25, 2017

SimonSapin commented Feb 25, 2017

emilio commented Feb 25, 2017

bors-servo commented Feb 25, 2017

bors-servo commented Feb 25, 2017

bors-servo commented Feb 25, 2017

SimonSapin commented Feb 25, 2017

bors-servo commented Feb 25, 2017

bors-servo commented Feb 25, 2017

SimonSapin commented Feb 25, 2017

bors-servo commented Feb 25, 2017

SimonSapin commented Feb 25, 2017

bors-servo commented Feb 25, 2017

SimonSapin commented Feb 26, 2017 • edited

bors-servo commented Feb 26, 2017

bors-servo commented Feb 26, 2017

bors-servo commented Feb 26, 2017

bors-servo commented Feb 26, 2017

bors-servo commented Feb 26, 2017

SimonSapin commented Feb 25, 2017 •

edited by larsbergstrom

SimonSapin commented Feb 26, 2017 •

edited