Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1341083: Implement dynamic restyling for display: contents. #15736

Merged
merged 1 commit into from Feb 25, 2017

Conversation

Projects
None yet
5 participants
@emilio
Copy link
Member

commented Feb 25, 2017

Reviewed upstream by @heycam

cc @bholley, didn't end up renaming the layout_parent thing, because it made the cascade way more verbose (and difficult to understand IMO) unnecessarily, and you said you were ok-ish with it.


This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Feb 25, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/gecko.mako.rs, components/style/values/computed/mod.rs, components/style/animation.rs, components/style/viewport.rs, components/style/matching.rs, components/style/properties/properties.mako.rs, components/style/gecko/media_queries.rs, components/style/stylist.rs
@highfive

This comment has been minimized.

Copy link

commented Feb 25, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio

This comment has been minimized.

Copy link
Member Author

commented Feb 25, 2017

@bors-servo r=heycam

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2017

📌 Commit 0a2556a has been approved by heycam

@highfive highfive assigned heycam and unassigned mbrubeck Feb 25, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2017

⌛️ Testing commit 0a2556a with merge 8403fd6...

bors-servo added a commit that referenced this pull request Feb 25, 2017

Auto merge of #15736 - servo:display-contents, r=heycam
Bug 1341083: Implement dynamic restyling for display: contents.

Reviewed upstream by @heycam

cc @bholley, didn't end up renaming the `layout_parent` thing, because it made the cascade way more verbose (and difficult to understand IMO) unnecessarily, and you said you were ok-ish with it.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15736)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2017

💔 Test failed - linux-rel-wpt

@emilio emilio force-pushed the display-contents branch from 0a2556a to 39cd718 Feb 25, 2017

@emilio

This comment has been minimized.

Copy link
Member Author

commented Feb 25, 2017

@bors-servo r=heycam

  • Added missing default-field in the media-query code
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2017

📌 Commit 39cd718 has been approved by heycam

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2017

⌛️ Testing commit 39cd718 with merge 8e4b9d7...

bors-servo added a commit that referenced this pull request Feb 25, 2017

Auto merge of #15736 - servo:display-contents, r=heycam
Bug 1341083: Implement dynamic restyling for display: contents.

Reviewed upstream by @heycam

cc @bholley, didn't end up renaming the `layout_parent` thing, because it made the cascade way more verbose (and difficult to understand IMO) unnecessarily, and you said you were ok-ish with it.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15736)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2017

💔 Test failed - linux-dev

Bug 1341083: Implement dynamic restyling for display: contents. r=heycam
MozReview-Commit-ID: KimTU2j4V4p
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>

@emilio emilio force-pushed the display-contents branch from 39cd718 to 6875c65 Feb 25, 2017

@emilio

This comment has been minimized.

Copy link
Member Author

commented Feb 25, 2017

@bors-servo retry

  • Unit tests
@emilio

This comment has been minimized.

Copy link
Member Author

commented Feb 25, 2017

@bors-servo r=heycam

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2017

📌 Commit 6875c65 has been approved by heycam

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2017

⌛️ Testing commit 6875c65 with merge b77140a...

bors-servo added a commit that referenced this pull request Feb 25, 2017

Auto merge of #15736 - servo:display-contents, r=heycam
Bug 1341083: Implement dynamic restyling for display: contents.

Reviewed upstream by @heycam

cc @bholley, didn't end up renaming the `layout_parent` thing, because it made the cascade way more verbose (and difficult to understand IMO) unnecessarily, and you said you were ok-ish with it.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15736)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2017

💡 This pull request was already approved, no need to approve it again.

  • This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2017

📌 Commit 6875c65 has been approved by heycam

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2017

@bors-servo bors-servo merged commit 6875c65 into master Feb 25, 2017

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details

@SimonSapin SimonSapin deleted the display-contents branch Mar 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.