Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow keyword values in min/max-size properties in the block direction #15739

Merged
merged 1 commit into from Feb 26, 2017

Conversation

Projects
None yet
4 participants
@Manishearth
Copy link
Member

commented Feb 26, 2017

@highfive

This comment has been minimized.

Copy link

commented Feb 26, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/position.mako.rs
  • @emilio: components/style/properties/longhand/position.mako.rs
@highfive

This comment has been minimized.

Copy link

commented Feb 26, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@Manishearth

This comment has been minimized.

Copy link
Member Author

commented Feb 26, 2017

@bors-servo r=xidorn

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2017

📌 Commit 48bc25c has been approved by xidorn

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2017

⌛️ Testing commit 48bc25c with merge a256746...

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2017

💔 Test failed - linux-rel-wpt

@Manishearth Manishearth force-pushed the Manishearth:fix-wm branch from 48bc25c to 3721b8b Feb 26, 2017

@Manishearth

This comment has been minimized.

Copy link
Member Author

commented Feb 26, 2017

@bors-servo r=xidorn

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2017

📌 Commit 3721b8b has been approved by xidorn

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2017

⌛️ Testing commit 3721b8b with merge f8f7b37...

bors-servo added a commit that referenced this pull request Feb 26, 2017

Auto merge of #15739 - Manishearth:fix-wm, r=xidorn
Disallow keyword values in min/max-size properties in the block direction

r=xidorn from https://bugzilla.mozilla.org/show_bug.cgi?id=1342710

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15739)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2017

💔 Test failed - linux-rel-css

@Manishearth

This comment has been minimized.

Copy link
Member Author

commented Feb 26, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2017

⚡️ Previous build results for arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, windows-gnu-dev, windows-msvc-dev are reusable. Rebuilding only android, linux-rel-css, mac-rel-wpt2...

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2017

@bors-servo bors-servo merged commit 3721b8b into servo:master Feb 26, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@Manishearth Manishearth deleted the Manishearth:fix-wm branch Feb 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.