Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade synstructure to 0.4.0 #15744

Merged
merged 1 commit into from Feb 26, 2017

Conversation

Projects
None yet
5 participants
@nox
Copy link
Member

commented Feb 26, 2017

This change is Reviewable

Downgrade synstructure to 0.4.0
0.4.1 had a breaking change from supporting both syn 0.10 and syn 0.11, which
does not play well with Cargo's habit to select the highest dependency versions
when trying to update a crate, even if that introduces multiple versions of a
single crate.
@SimonSapin

This comment has been minimized.

Copy link
Member

commented Feb 26, 2017

nox> (0.4.1 was yanked.)
SimonSapin> if the yanked version works for us, why downgrade?
nox> SimonSapin: Because sometimes cargo will update syn in synstructure,
nox> and then you have unrelated build failures,
nox> it happened to avadacatavra multiple times during her Hyper bump.
SimonSapin> ok

@bors-servo r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2017

📌 Commit db94f40 has been approved by SimonSapin

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2017

⌛️ Testing commit db94f40 with merge 6318c4b...

bors-servo added a commit that referenced this pull request Feb 26, 2017

Auto merge of #15744 - nox:synstructure, r=SimonSapin
Downgrade synstructure to 0.4.0

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15744)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2017

💔 Test failed - linux-rel-css

@nox

This comment has been minimized.

Copy link
Member Author

commented Feb 26, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2017

⚡️ Previous build results for android, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev are reusable. Rebuilding only linux-rel-css...

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: SimonSapin
Pushing 6318c4b to master...

@bors-servo bors-servo merged commit db94f40 into servo:master Feb 26, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.