Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong index for missing properties in keyframes #15747

Merged
merged 1 commit into from Feb 27, 2017

Conversation

@hiikezoe
Copy link
Contributor

commented Feb 26, 2017

This is PR of https://bugzilla.mozilla.org/show_bug.cgi?id=1342323 , reviewed by @emilio. Thank you Emilio!


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because it's for stylo.

I think we have test cases for this in gecko tree.


This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Feb 26, 2017

Heads up! This PR modifies the following files:

@highfive

This comment has been minimized.

Copy link

commented Feb 26, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@emilio

This comment has been minimized.

Copy link
Member

commented Feb 27, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2017

📌 Commit 8ced5db has been approved by emilio

@highfive highfive assigned emilio and unassigned pcwalton Feb 27, 2017
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2017

⌛️ Testing commit 8ced5db with merge 29e3347...

bors-servo added a commit that referenced this pull request Feb 27, 2017
Fix wrong index for missing properties in keyframes

<!-- Please describe your changes on the following line: -->
This is PR of https://bugzilla.mozilla.org/show_bug.cgi?id=1342323 , reviewed by @emilio.  Thank you Emilio!

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because it's for stylo.

I think we have test cases for this in gecko tree.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15747)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2017

@bors-servo bors-servo merged commit 8ced5db into servo:master Feb 27, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@hiikezoe hiikezoe deleted the hiikezoe:fix-wrong-index-in-keyframe branch Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.