Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WR (image tiling, inset box shadow fixes, new key api). #15749

Merged
merged 1 commit into from Feb 27, 2017

Conversation

Projects
None yet
6 participants
@glennw
Copy link
Member

commented Feb 26, 2017

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Feb 26, 2017

Heads up! This PR modifies the following files:

  • @KiChjang: components/net/image_cache_thread.rs
  • @emilio: components/canvas/webgl_paint_thread.rs
@highfive

This comment has been minimized.

Copy link

commented Feb 26, 2017

warning Warning warning

  • These commits modify gfx and net code, but no tests are modified. Please consider adding a test!
@glennw

This comment has been minimized.

Copy link
Member Author

commented Feb 26, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2017

⌛️ Trying commit 64a9a45 with merge 700dfe4...

bors-servo added a commit that referenced this pull request Feb 26, 2017

Auto merge of #15749 - glennw:update-wr-tiling, r=<try>
Update WR (image tiling, inset box shadow fixes, new key api).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15749)
<!-- Reviewable:end -->
@nox

This comment has been minimized.

Copy link
Member

commented Feb 26, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2017

📌 Commit 64a9a45 has been approved by nox

@highfive highfive assigned nox and unassigned mbrubeck Feb 26, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2017

💔 Test failed - arm32

@nox

This comment has been minimized.

Copy link
Member

commented Feb 26, 2017

@bors-servo try- retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2017

⌛️ Testing commit 64a9a45 with merge c025a79...

bors-servo added a commit that referenced this pull request Feb 26, 2017

Auto merge of #15749 - glennw:update-wr-tiling, r=nox
Update WR (image tiling, inset box shadow fixes, new key api).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15749)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2017

@bors-servo bors-servo merged commit 64a9a45 into servo:master Feb 27, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@bors-servo bors-servo referenced this pull request Feb 27, 2017

Closed

Wrap CGFont in NativeFontHandle #15615

4 of 4 tasks complete

@glennw glennw deleted the glennw:update-wr-tiling branch Feb 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.