Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't serialize shorthand if some but not all its longhands have CSS-wide keyword #15779

Merged
merged 5 commits into from Mar 2, 2017

Conversation

@upsuper
Copy link
Member

commented Mar 1, 2017

This also changes LonghandsToSerialize to store references to specified value directly rather than declared value, which significantly simplify many serialization code.


This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Mar 1, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/shorthand/background.mako.rs, components/style/properties/shorthand/mask.mako.rs, components/style/properties/shorthand/box.mako.rs, components/style/properties/helpers/animated_properties.mako.rs, components/style/custom_properties.rs, components/style/properties/shorthand/serialize.mako.rs, components/style/properties/shorthand/inherited_text.mako.rs, components/style/properties/shorthand/text.mako.rs, components/style/properties/shorthand/column.mako.rs, components/style/properties/shorthand/position.mako.rs, components/style/properties/helpers.mako.rs, components/style/properties/shorthand/font.mako.rs, components/style/properties/shorthand/border.mako.rs, components/style/properties/shorthand/inherited_svg.mako.rs, components/style/properties/shorthand/list.mako.rs, components/style/properties/properties.mako.rs, components/style/properties/shorthand/outline.mako.rs
  • @emilio: components/style/properties/shorthand/background.mako.rs, components/style/properties/shorthand/mask.mako.rs, components/style/properties/shorthand/box.mako.rs, components/style/properties/helpers/animated_properties.mako.rs, components/style/custom_properties.rs, components/style/properties/shorthand/serialize.mako.rs, components/style/properties/shorthand/inherited_text.mako.rs, components/style/properties/shorthand/text.mako.rs, components/style/properties/shorthand/column.mako.rs, components/style/properties/shorthand/position.mako.rs, components/style/properties/helpers.mako.rs, components/style/properties/shorthand/font.mako.rs, components/style/properties/shorthand/border.mako.rs, components/style/properties/shorthand/inherited_svg.mako.rs, components/style/properties/shorthand/list.mako.rs, components/style/properties/properties.mako.rs, components/style/properties/shorthand/outline.mako.rs
@upsuper

This comment has been minimized.

Copy link
Member Author

commented Mar 1, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2017

⌛️ Trying commit 684f486 with merge 6a4e8b8...

bors-servo added a commit that referenced this pull request Mar 1, 2017
[WIP] Don't serialize shorthand if some but not all its longhands have CSS-wide keyword

This also changes `LonghandsToSerialize` to store references to specified value directly rather than declared value, which significantly simplify many serialization code.
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2017

@upsuper

This comment has been minimized.

Copy link
Member Author

commented Mar 1, 2017

@upsuper upsuper changed the title [WIP] Don't serialize shorthand if some but not all its longhands have CSS-wide keyword Don't serialize shorthand if some but not all its longhands have CSS-wide keyword Mar 1, 2017
@emilio

This comment has been minimized.

Copy link
Member

commented Mar 1, 2017

r=me when rebased

upsuper added 5 commits Feb 28, 2017
Rather than having separate variant for each CSS-wide keyword.
…CSS-wide keyword

Shorthand cannot represent CSS-wide keyword in individual longhands, and
thus we cannot serialize longhand with CSS-wide keyword as part of a
shorthand.
@upsuper upsuper force-pushed the upsuper:shorthand branch from 684f486 to 4bc0fbe Mar 2, 2017
@upsuper

This comment has been minimized.

Copy link
Member Author

commented Mar 2, 2017

@bors-servo r=emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2017

📌 Commit 4bc0fbe has been approved by emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2017

⌛️ Testing commit 4bc0fbe with merge c87524c...

bors-servo added a commit that referenced this pull request Mar 2, 2017
Don't serialize shorthand if some but not all its longhands have CSS-wide keyword

This also changes `LonghandsToSerialize` to store references to specified value directly rather than declared value, which significantly simplify many serialization code.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15779)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2017

@bors-servo bors-servo merged commit 4bc0fbe into servo:master Mar 2, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
bors-servo added a commit that referenced this pull request Mar 2, 2017
Fix animation shorthand parsing

which is somehow broken after #15779.

But it seems there are various issue around the animation shorthand parsing, so I try to fix it to make it match the spec.

I expect this change to fix most parsing failures in Gecko's test suite, although I haven't tested.
bors-servo added a commit that referenced this pull request Mar 2, 2017
Fix animation shorthand parsing

which is somehow broken after #15779.

But it seems there are various issue around the animation shorthand parsing, so I try to fix it to make it match the spec.

I expect this change to fix most parsing failures in Gecko's test suite, although I haven't tested.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15793)
<!-- Reviewable:end -->
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Mar 2, 2017
…rvo/servo#15779.

--HG--
extra : rebase_source : a8b7ded88c6af24658ac2d23a036834b5d022209
bors-servo added a commit that referenced this pull request Mar 2, 2017
Fix animation shorthand parsing

which is somehow broken after #15779.

But it seems there are various issue around the animation shorthand parsing, so I try to fix it to make it match the spec.

I expect this change to fix most parsing failures in Gecko's test suite, although I haven't tested.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15793)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Mar 3, 2017
Fix animation shorthand parsing

which is somehow broken after #15779.

But it seems there are various issue around the animation shorthand parsing, so I try to fix it to make it match the spec.

I expect this change to fix most parsing failures in Gecko's test suite, although I haven't tested.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15793)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Mar 3, 2017
Fix animation shorthand parsing

which is somehow broken after #15779.

But it seems there are various issue around the animation shorthand parsing, so I try to fix it to make it match the spec.

I expect this change to fix most parsing failures in Gecko's test suite, although I haven't tested.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15793)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Mar 3, 2017
Fix animation shorthand parsing

which is somehow broken after #15779.

But it seems there are various issue around the animation shorthand parsing, so I try to fix it to make it match the spec.

I expect this change to fix most parsing failures in Gecko's test suite, although I haven't tested.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15793)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Mar 3, 2017
Fix animation shorthand parsing

which is somehow broken after #15779.

But it seems there are various issue around the animation shorthand parsing, so I try to fix it to make it match the spec.

I expect this change to fix most parsing failures in Gecko's test suite, although I haven't tested.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15793)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Mar 3, 2017
Fix animation shorthand parsing

which is somehow broken after #15779.

But it seems there are various issue around the animation shorthand parsing, so I try to fix it to make it match the spec.

I expect this change to fix most parsing failures in Gecko's test suite, although I haven't tested.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15793)
<!-- Reviewable:end -->
Manishearth pushed a commit to Manishearth/gecko-dev that referenced this pull request Mar 13, 2017
JerryShih pushed a commit to JerryShih/gecko-dev that referenced this pull request Mar 13, 2017
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 1, 2019
…rvo/servo#15779.

UltraBlame original commit: 2e877886c769b49574a6af5ceeac16ccbc50d4cb
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 1, 2019
…rvo/servo#15779.

UltraBlame original commit: 2e877886c769b49574a6af5ceeac16ccbc50d4cb
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 1, 2019
…rvo/servo#15779.

UltraBlame original commit: 2e877886c769b49574a6af5ceeac16ccbc50d4cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.