Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1340334: Allow sibling hints in StoredRestyleHint, and handle them correctly. #15791

Merged
merged 1 commit into from Mar 2, 2017

Conversation

@emilio
Copy link
Member

commented Mar 2, 2017

Reviewed upstream by Bobby.


This change is Reviewable

…m correctly. r=bholley

MozReview-Commit-ID: H6NuKsfjEdj
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
@highfive

This comment has been minimized.

Copy link

commented Mar 2, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/data.rs, components/style/traversal.rs
@highfive

This comment has been minimized.

Copy link

commented Mar 2, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio

This comment has been minimized.

Copy link
Member Author

commented Mar 2, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2017

📌 Commit 32bf809 has been approved by bholley

@highfive highfive assigned bholley and unassigned nox Mar 2, 2017
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2017

⌛️ Testing commit 32bf809 with merge d0856fd...

bors-servo added a commit that referenced this pull request Mar 2, 2017
Bug 1340334: Allow sibling hints in StoredRestyleHint, and handle them correctly.

Reviewed upstream by Bobby.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15791)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2017

💔 Test failed - linux-rel-css

@emilio

This comment has been minimized.

Copy link
Member Author

commented Mar 2, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2017

⚡️ Previous build results for arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev are reusable. Rebuilding only android, linux-rel-css, mac-rel-css...

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: bholley
Pushing d0856fd to master...

@bors-servo bors-servo merged commit 32bf809 into servo:master Mar 2, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.