Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to our own websocket fork #15798

Merged
merged 2 commits into from Mar 2, 2017

Conversation

Projects
None yet
6 participants
@nox
Copy link
Member

commented Mar 2, 2017

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Mar 2, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/Cargo.toml
  • @KiChjang: components/net/Cargo.toml, components/script/Cargo.toml, components/net_traits/Cargo.toml, components/net_traits/Cargo.toml
@highfive

This comment has been minimized.

Copy link

commented Mar 2, 2017

warning Warning warning

  • These commits modify net and script code, but no tests are modified. Please consider adding a test!
@nox

This comment has been minimized.

Copy link
Member Author

commented Mar 2, 2017

@Ms2ger

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2017

r=me iff taking an Apache2.0-only dep (bitreader) is okay

@SimonSapin

This comment has been minimized.

Copy link
Member

commented Mar 2, 2017

@nox for posterity, can you write here why we’re forking?

@nox

This comment has been minimized.

Copy link
Member Author

commented Mar 2, 2017

Maintainer is AWOL and it needs a hyper bump.

@nox nox force-pushed the nox:websocket branch from 288f557 to da45177 Mar 2, 2017

@nox

This comment has been minimized.

Copy link
Member Author

commented Mar 2, 2017

I removed the audio-video-metadata bump that brings the Apache-2.0-only dependency.

@bors-servo r=Ms2ger

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2017

📌 Commit da45177 has been approved by Ms2ger

@highfive highfive assigned Ms2ger and unassigned glennw Mar 2, 2017

bors-servo added a commit that referenced this pull request Mar 2, 2017

Auto merge of #15798 - nox:websocket, r=Ms2ger
Switch to our own websocket fork

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15798)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2017

⌛️ Testing commit da45177 with merge dabbdaf...

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2017

@bors-servo bors-servo merged commit da45177 into servo:master Mar 2, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.