Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WR (reference frames for fixed position elements). #15804

Merged
merged 1 commit into from Mar 3, 2017

Conversation

@glennw
Copy link
Member

commented Mar 2, 2017

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Mar 2, 2017

Heads up! This PR modifies the following files:

  • @emilio: components/layout/fragment.rs, components/layout/block.rs, components/layout/webrender_helpers.rs, components/layout/flow.rs
@highfive

This comment has been minimized.

Copy link

commented Mar 2, 2017

warning Warning warning

  • These commits modify gfx and layout code, but no tests are modified. Please consider adding a test!
@glennw

This comment has been minimized.

Copy link
Member Author

commented Mar 2, 2017

@highfive highfive assigned pcwalton and unassigned nox Mar 2, 2017
@glennw

This comment has been minimized.

Copy link
Member Author

commented Mar 2, 2017

WR needs to know whether a transform / perspective element exists. This is required because the containing block of position: fixed elements is the nearest parent with a transform set (see https://drafts.csswg.org/css-transforms-2/#perspective-property).

This update changes the transform / perspective properties to be Options that are passed through to WR, in order to enable correct positioning for fixed elements under a transform root.

@pcwalton

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2017

I wonder if it would be better to Box the matrices (or maybe just perspective?) now, to avoid copies. Most stacking contexts don't have a 3D transform set...

@pcwalton

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2017

📌 Commit 6223f67 has been approved by pcwalton

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2017

⌛️ Testing commit 6223f67 with merge 28c507b...

bors-servo added a commit that referenced this pull request Mar 2, 2017
Update WR (reference frames for fixed position elements).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15804)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 3, 2017

💔 Test failed - linux-rel-css

@glennw glennw force-pushed the glennw:update-wr-transforms branch from 6223f67 to 750794e Mar 3, 2017
@glennw

This comment has been minimized.

Copy link
Member Author

commented Mar 3, 2017

@bors-servo r=pcwalton

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 3, 2017

📌 Commit 750794e has been approved by pcwalton

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 3, 2017

⌛️ Testing commit 750794e with merge 0f6b5c3...

bors-servo added a commit that referenced this pull request Mar 3, 2017
Update WR (reference frames for fixed position elements).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15804)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 3, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: pcwalton
Pushing 0f6b5c3 to master...

@bors-servo bors-servo merged commit 750794e into servo:master Mar 3, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.