Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout_thread: Also reposition elements when reflowing all nodes. #15805

Merged
merged 4 commits into from Mar 3, 2017

Conversation

Projects
None yet
5 participants
@emilio
Copy link
Member

commented Mar 3, 2017

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Mar 3, 2017

Heads up! This PR modifies the following files:

@highfive

This comment has been minimized.

Copy link

commented Mar 3, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio

This comment has been minimized.

Copy link
Member Author

commented Mar 3, 2017

r? @glennw

@highfive highfive assigned glennw and unassigned pcwalton Mar 3, 2017

@glennw

This comment has been minimized.

Copy link
Member

commented Mar 3, 2017

r=me - not sure if you want to squash or leave as separate commits.

@emilio

This comment has been minimized.

Copy link
Member Author

commented Mar 3, 2017

@bors-servo r=glennw

  • I know I should add a test for this, but the only reliable way of testing this as of right now is via iframes, and those are not very reliable and end up adding intermittent failures frequently. I'll file an issue to add an API to TestBinding to modify page zoom instead, and add the test case from the issue when it's done.
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 3, 2017

📌 Commit 250b6ce has been approved by glennw

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 3, 2017

⌛️ Testing commit 250b6ce with merge f223f24...

bors-servo added a commit that referenced this pull request Mar 3, 2017

Auto merge of #15805 - emilio:reposition, r=glennw
layout_thread: Also reposition elements when reflowing all nodes.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15805)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 3, 2017

💔 Test failed - mac-dev-unit

emilio added some commits Mar 2, 2017

@emilio emilio force-pushed the emilio:reposition branch from 250b6ce to 8832b5a Mar 3, 2017

@emilio

This comment has been minimized.

Copy link
Member Author

commented Mar 3, 2017

@bors-servo r=glennw

  • Fixed geckolib warning that broke the build
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 3, 2017

📌 Commit 8832b5a has been approved by glennw

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 3, 2017

⌛️ Testing commit 8832b5a with merge aeb7ab8...

bors-servo added a commit that referenced this pull request Mar 3, 2017

Auto merge of #15805 - emilio:reposition, r=glennw
layout_thread: Also reposition elements when reflowing all nodes.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15805)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 3, 2017

@bors-servo bors-servo merged commit 8832b5a into servo:master Mar 3, 2017

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.