Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: Backport rust-nsstring crash fixes to the vendored version. #15809

Merged
merged 1 commit into from Mar 3, 2017

Conversation

Projects
None yet
4 participants
@emilio
Copy link
Member

commented Mar 3, 2017

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Mar 3, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko_bindings/nsstring_vendor/src/lib.rs
@highfive

This comment has been minimized.

Copy link

commented Mar 3, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio

This comment has been minimized.

Copy link
Member Author

commented Mar 3, 2017

@bors-servo r+ p=1

  • Self-r+'ing for the revendoring part. The fix was reviewed upstream by @mystor.
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 3, 2017

📌 Commit feac01f has been approved by emilio

@highfive highfive assigned emilio and unassigned cbrewster Mar 3, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 3, 2017

⌛️ Testing commit feac01f with merge c32181c...

bors-servo added a commit that referenced this pull request Mar 3, 2017

Auto merge of #15809 - emilio:nsstuff, r=emilio
stylo: Backport rust-nsstring crash fixes to the vendored version.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15809)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 3, 2017

@bors-servo bors-servo merged commit feac01f into servo:master Mar 3, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.