Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more XUL properties #15817

Merged
merged 1 commit into from Mar 4, 2017

Conversation

Projects
None yet
6 participants
@Manishearth
Copy link
Member

commented Mar 4, 2017


This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Mar 4, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/xul.mako.rs
  • @emilio: components/style/properties/longhand/xul.mako.rs
@highfive

This comment has been minimized.

Copy link

commented Mar 4, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@bholley

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2017

@bors-servo delegate+

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2017

✌️ @Manishearth can now approve this pull request

@Manishearth

This comment has been minimized.

Copy link
Member Author

commented Mar 4, 2017

@bors-servo r=bholley

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2017

📌 Commit 58d32b2 has been approved by bholley

@highfive highfive assigned bholley and unassigned heycam Mar 4, 2017

bors-servo added a commit that referenced this pull request Mar 4, 2017

Auto merge of #15817 - Manishearth:xul, r=bholley
Support more XUL properties

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15817)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2017

⌛️ Testing commit 58d32b2 with merge 78210c3...

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: bholley
Pushing 78210c3 to master...

@bors-servo bors-servo merged commit 58d32b2 into servo:master Mar 4, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@Manishearth Manishearth deleted the Manishearth:xul branch Mar 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.