Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace match with if let #15827

Merged
merged 1 commit into from Mar 6, 2017

Conversation

@moonlightdrive
Copy link
Contributor

commented Mar 6, 2017

Use if let instead of a match with a single pattern.

I'm not clear if/how this needs to be tested (beyond what's been checked-off below), so please let me know if there's more to do. Thanks!


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #15810
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Mar 6, 2017

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @mbrubeck (or someone else) soon.

@highfive

This comment has been minimized.

Copy link

commented Mar 6, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/properties.mako.rs
  • @emilio: components/style/properties/properties.mako.rs
@highfive

This comment has been minimized.

Copy link

commented Mar 6, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@mbrubeck

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2017

@bors-servo r+

Thanks!

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2017

📌 Commit 27b6013 has been approved by mbrubeck

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2017

⌛️ Testing commit 27b6013 with merge 5ccf79e...

bors-servo added a commit that referenced this pull request Mar 6, 2017
replace match with if let

<!-- Please describe your changes on the following line: -->
Use `if let` instead of a `match` with a single pattern.

I'm not clear if/how this needs to be tested (beyond what's been checked-off below), so please let me know if there's more to do. Thanks!

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #15810

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15827)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: mbrubeck
Pushing 5ccf79e to master...

@bors-servo bors-servo merged commit 27b6013 into servo:master Mar 6, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@moonlightdrive moonlightdrive deleted the moonlightdrive:use-iflet-not-match branch Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.