Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upintroduce frame_size and window_rect #15831
Merged
Conversation
|
r=me after those minor nits are addressed. |
ports/glutin/window.rs
Outdated
| @@ -797,6 +798,12 @@ impl WindowMethods for Window { | |||
| } | |||
| } | |||
|
|
|||
| fn window_rect(&self) -> TypedRect<u32, DevicePixel> { | |||
| let size = self.framebuffer_size(); | |||
| let origin = TypedPoint2D::new(0, 0); | |||
This comment has been minimized.
This comment has been minimized.
ports/cef/window.rs
Outdated
| @@ -206,6 +207,12 @@ impl WindowMethods for Window { | |||
| } | |||
| } | |||
|
|
|||
| fn window_rect(&self) -> TypedRect<u32, DevicePixel> { | |||
| let size = self.framebuffer_size(); | |||
| let origin = TypedPoint2D::new(0, 0); | |||
This comment has been minimized.
This comment has been minimized.
|
Nits addressed. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 7, 2017
introduce frame_size and window_rect follow up of servo/webrender#951 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix webrender/issues/833 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because I don't know how to test that feature <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15831) <!-- Reviewable:end -->
|
|
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 7, 2017
introduce frame_size and window_rect follow up of servo/webrender#951 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix webrender/issues/833 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because I don't know how to test that feature <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15831) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
paulrouget commentedMar 6, 2017
•
edited by larsbergstrom
follow up of servo/webrender#951
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is