Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing mutHeapJs references #15833

Merged
merged 1 commit into from Mar 7, 2017
Merged

removing mutHeapJs references #15833

merged 1 commit into from Mar 7, 2017

Conversation

@sendilkumarn
Copy link
Contributor

sendilkumarn commented Mar 6, 2017 •
edited by larsbergstrom

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #15316

This change is Reviewable
@highfive
Copy link

highfive commented Mar 6, 2017

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @wafflespeanut (or someone else) soon.
@highfive
Copy link

highfive commented Mar 6, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/xmlhttprequest.rs, components/script/dom/bindings/callback.rs, components/script/dom/errorevent.rs, components/script/dom/popstateevent.rs, components/script/dom/customevent.rs, components/script/dom/bindings/js.rs, components/script/dom/promise.rs
  • @KiChjang: components/script/dom/xmlhttprequest.rs, components/script/dom/bindings/callback.rs, components/script/dom/errorevent.rs, components/script/dom/popstateevent.rs, components/script/dom/customevent.rs, components/script/dom/bindings/js.rs, components/script/dom/promise.rs
@highfive
Copy link

highfive commented Mar 6, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@KiChjang
Copy link
Member

KiChjang commented Mar 6, 2017 •
edited

I'm pretty sure this is still the wrong fix. The issue specifically asked for removing MutHeapJSVal and replace it with Heap<JSVal> , and not renaming MutHeapJSVal to HeapJSVal.
@nox
Copy link
Member

nox commented Mar 7, 2017

Please squash the 2 commits together and I'll r+ it.
@nox nox added S-needs-squash and removed S-awaiting-review labels Mar 7, 2017
@nox nox assigned nox and unassigned wafflespeanut Mar 7, 2017
@sendilkumarn
removing mutHeapJs references
Loading status checks…
2996d3a 
changes as per comments
@sendilkumarn sendilkumarn force-pushed the sendilkumarn:mut-js-heap branch from 311575c to 2996d3a Mar 7, 2017
@sendilkumarn
Copy link
Contributor Author

sendilkumarn commented Mar 7, 2017

@nox done 👍
@nox
Copy link
Member

nox commented Mar 7, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2017

📌 Commit 2996d3a has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2017

⌛ Testing commit 2996d3a with merge b668393...
bors-servo added a commit that referenced this pull request Mar 7, 2017
@bors-servo
Auto merge of #15833 - sendilkumarn:mut-js-heap, r=nox
Loading status checks…
b668393 
removing mutHeapJs references

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #15316

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15833)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: nox
Pushing b668393 to master...
@bors-servo bors-servo merged commit 2996d3a into servo:master Mar 7, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Remove MutHeapJSVal
6 participants
@sendilkumarn @highfive @KiChjang @nox @bors-servo @wafflespeanut
You can’t perform that action at this time.