Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not Merge: Webpki certificate verification #15845

Closed
wants to merge 5 commits into from
Closed

Do not Merge: Webpki certificate verification #15845

wants to merge 5 commits into from

Conversation

@avadacatavra
Copy link
Contributor

avadacatavra commented Mar 6, 2017 •
edited by larsbergstrom

See https://avadacatavra.github.io/servo/2016/02/07/webpkiresults.html, ctz/rustls#47, and briansmith/webpki#37

This is a work in progress

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
avadacatavra and others added 5 commits Jan 11, 2017
@avadacatavra
updated files for openssl bump, changed to hyper_openssl::opensslclient
Loading status checks…
fc0c616 
fixed new wrapped hyper to handle strings per hyper 10

bumped to cookie 0.6

use serde_json to persist cookies in net crate

fixed tests to be compatible with new cookie version

fixed case mismatch with domain test

bumped to webdriver 0.22
avinash @avadacatavra
Add ServoUrl as a parameter to report_error(...) of ParseErrorReporter
f990b0c 
passes test-tidy
removed match and used map

added new test test_report_error_passing_correct_url(...) and modified old unit tests

removed the option for servourl and tidied up

removed the duplicate test.

made a few more changes after @cbrewster suggestions.

changed _url to url in few places

fixed the indenting
@avadacatavra
updated files for openssl bump
60d4402
@avadacatavra
moved perf output to different branch
96f912d 
changed to rustls parallel verify
@avadacatavra
rebased to hyper bump. WIP
Loading status checks…
7d1f139
@highfive
Copy link

highfive commented Mar 6, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/error_reporting.rs, components/style/parser.rs, components/style/stylesheets.rs
  • @jgraham: components/webdriver_server/lib.rs, components/webdriver_server/Cargo.toml
  • @emilio: components/style/error_reporting.rs, components/style/parser.rs, components/style/stylesheets.rs
  • @fitzgen: components/devtools_traits/Cargo.toml, components/devtools_traits/Cargo.toml, components/devtools/Cargo.toml, components/script/dom/document.rs, components/script/webdriver_handlers.rs, components/script/Cargo.toml, components/script/dom/websocket.rs, components/script_traits/webdriver_msg.rs, components/script_traits/webdriver_msg.rs, components/script_traits/Cargo.toml, components/script_traits/Cargo.toml, components/script_layout_interface/reporter.rs
  • @KiChjang: components/net/lib.rs, components/script/dom/document.rs, components/net/http_loader.rs, components/net/connector.rs, components/net_traits/lib.rs, components/net_traits/lib.rs, components/script/webdriver_handlers.rs, components/script/Cargo.toml, components/net/cookie_storage.rs, components/net_traits/Cargo.toml, components/net_traits/Cargo.toml, components/net/resource_thread.rs, components/net/Cargo.toml, components/net/cookie.rs, components/net/subresource_integrity.rs, components/script/dom/websocket.rs, components/script_traits/webdriver_msg.rs, components/script_traits/webdriver_msg.rs, components/script_traits/Cargo.toml, components/script_traits/Cargo.toml, components/script_layout_interface/reporter.rs
  • @asajeffrey: components/webdriver_server/lib.rs, components/webdriver_server/Cargo.toml
@avadacatavra avadacatavra assigned avadacatavra and unassigned pcwalton Mar 6, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Mar 8, 2017

☔ The latest upstream changes (presumably #15849) made this pull request unmergeable. Please resolve the merge conflicts.
@jdm
Copy link
Member

jdm commented Apr 12, 2017

I don't see any reason to leave this open until it's being actively worked on again.
@jdm jdm closed this Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@avadacatavra avadacatavra

Labels
S-awaiting-review S-needs-rebase
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@avadacatavra @highfive @bors-servo @jdm @pcwalton
You can’t perform that action at this time.