style: Iterate the LRU cache contents from back to front. #15891

emilio · 2017-03-09T16:03:27Z

This is on top of #15888. Only the second commit needs review.

We put the more recently used item last, so iterating then from left to right is
pointless.

This change is

highfive · 2017-03-09T16:03:35Z

Heads up! This PR modifies the following files:

@bholley: components/style/cache.rs, components/style/matching.rs

highfive · 2017-03-09T16:03:36Z

Warning

These commits modify style code, but no tests are modified. Please consider adding a test!

emilio · 2017-03-09T16:03:37Z

r? @SimonSapin or @bholley

bholley · 2017-03-09T20:14:59Z

File an E-Easy for converting this cache to a VecDeque to avoid memmoving each time we need to pop the least-recently-used entry?

@bors-servo delegate+

bors-servo · 2017-03-09T20:15:01Z

✌️ @emilio can now approve this pull request

emilio · 2017-03-09T20:22:48Z

File an E-Easy for converting this cache to a VecDeque to avoid memmoving each time we need to pop the least-recently-used entry?

I don't think that happens a lot of times since we clear it often, but sure.

bors-servo · 2017-03-09T20:26:40Z

☔ The latest upstream changes (presumably #15888) made this pull request unmergeable. Please resolve the merge conflicts.

emilio · 2017-03-09T20:52:20Z

@bors-servo r=bholley

bors-servo · 2017-03-09T20:52:21Z

📌 Commit be42f4b has been approved by bholley

bors-servo · 2017-03-09T20:52:25Z

⌛ Testing commit be42f4b with merge 6280dba...

style: Iterate the LRU cache contents from back to front. This is on top of #15888. Only the second commit needs review. We put the more recently used item last, so iterating then from left to right is pointless.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15891)

bors-servo · 2017-03-09T21:32:14Z

💔 Test failed - mac-rel-css

emilio · 2017-03-09T23:46:46Z

@bors-servo retry

Subpixel difference near a border corner, huh

bors-servo · 2017-03-09T23:46:51Z

⌛ Testing commit be42f4b with merge 0be18f5...

style: Iterate the LRU cache contents from back to front. This is on top of #15888. Only the second commit needs review. We put the more recently used item last, so iterating then from left to right is pointless.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15891)

emilio · 2017-03-10T13:11:22Z

@bors-servo try

bors-servo · 2017-03-10T13:11:26Z

⌛ Trying commit eecd38a with merge 3b9a074...

style: Iterate the LRU cache contents from back to front. This is on top of #15888. Only the second commit needs review. We put the more recently used item last, so iterating then from left to right is pointless.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15891)

bors-servo · 2017-03-10T13:51:35Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
State: approved= try=True

emilio · 2017-03-10T14:43:19Z

Last commit fixes the reftests failures, I've asked @mbrubeck to take a look.

mbrubeck · 2017-03-10T20:23:57Z

r=mbrubeck for the layout fix

emilio · 2017-03-11T00:13:29Z

@bors-servo r=bholley,mbrubeck

bors-servo · 2017-03-11T00:13:30Z

📌 Commit eecd38a has been approved by bholley,mbrubeck

We put the more recently used item last, so iterating then from left to right is pointless.

emilio · 2017-03-11T10:31:22Z

@bors-servo r=bholley,mbrubeck

bors-servo · 2017-03-11T10:31:22Z

📌 Commit 4bafded has been approved by bholley,mbrubeck

bors-servo · 2017-03-11T10:31:26Z

⌛ Testing commit 4bafded with merge 7fa4a94...

style: Iterate the LRU cache contents from back to front. This is on top of #15888. Only the second commit needs review. We put the more recently used item last, so iterating then from left to right is pointless.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15891)

bors-servo · 2017-03-11T11:11:02Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: bholley,mbrubeck
Pushing 7fa4a94 to master...

highfive assigned Manishearth Mar 9, 2017

highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 9, 2017

highfive assigned SimonSapin and unassigned Manishearth Mar 9, 2017

highfive added the S-needs-rebase There are merge conflict errors. label Mar 9, 2017

emilio force-pushed the lru-back-to-front branch from 5da67e3 to be42f4b Compare March 9, 2017 20:52

highfive assigned bholley and unassigned SimonSapin Mar 9, 2017

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. S-needs-rebase There are merge conflict errors. labels Mar 9, 2017

highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Mar 9, 2017

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Mar 9, 2017

emilio mentioned this pull request Mar 10, 2017

Some reftests rely on how style sharing works. #15907

Open

highfive removed the S-tests-failed The changes caused existing tests to fail. label Mar 10, 2017

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 11, 2017

emilio added 5 commits March 11, 2017 11:31

style: Iterate the LRU cache contents from back to front.

d3e7f1f

We put the more recently used item last, so iterating then from left to right is pointless.

style: Add the traversal kind to the style stats.

58c6aad

gfx: Show the text in the display item when debugging.

ebdc6f6

layout: Reflow some code and comments in layout/inline.rs

6f13489

layout: Merge inline nodes based on node address, not node style.

4bafded

emilio force-pushed the lru-back-to-front branch from eecd38a to 4bafded Compare March 11, 2017 10:31

highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Mar 11, 2017

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 11, 2017

bors-servo merged commit 4bafded into servo:master Mar 11, 2017

highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 11, 2017

emilio deleted the lru-back-to-front branch March 23, 2017 00:42

Uh oh!

style: Iterate the LRU cache contents from back to front. #15891

style: Iterate the LRU cache contents from back to front. #15891

Uh oh!

Conversation

emilio commented Mar 9, 2017 • edited by larsbergstrom Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

highfive commented Mar 9, 2017

Uh oh!

highfive commented Mar 9, 2017

Uh oh!

emilio commented Mar 9, 2017

Uh oh!

bholley commented Mar 9, 2017

Uh oh!

bors-servo commented Mar 9, 2017

Uh oh!

emilio commented Mar 9, 2017

Uh oh!

bors-servo commented Mar 9, 2017

Uh oh!

emilio commented Mar 9, 2017

Uh oh!

bors-servo commented Mar 9, 2017

Uh oh!

bors-servo commented Mar 9, 2017

Uh oh!

bors-servo commented Mar 9, 2017

Uh oh!

emilio commented Mar 9, 2017

Uh oh!

bors-servo commented Mar 9, 2017

Uh oh!

emilio commented Mar 10, 2017

Uh oh!

bors-servo commented Mar 10, 2017

Uh oh!

bors-servo commented Mar 10, 2017

Uh oh!

emilio commented Mar 10, 2017

Uh oh!

mbrubeck commented Mar 10, 2017

Uh oh!

emilio commented Mar 11, 2017

Uh oh!

bors-servo commented Mar 11, 2017

Uh oh!

emilio commented Mar 11, 2017

Uh oh!

bors-servo commented Mar 11, 2017

Uh oh!

bors-servo commented Mar 11, 2017

Uh oh!

bors-servo commented Mar 11, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

emilio commented Mar 9, 2017 •

edited by larsbergstrom

Loading