Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SVG presentation attributes #15893

Merged
merged 2 commits into from Mar 9, 2017
Merged

Support SVG presentation attributes #15893

merged 2 commits into from Mar 9, 2017

Conversation

@Manishearth
Copy link
Member

Manishearth commented Mar 9, 2017 •
edited by larsbergstrom

r=bz from https://bugzilla.mozilla.org/show_bug.cgi?id=1329093

This change is Reviewable
@Manishearth
stylo: Handle SVG presentation attributes
14d8eb9
@highfive
Copy link

highfive commented Mar 9, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko_bindings/bindings.rs, components/style/gecko_bindings/structs_debug.rs, components/style/build_gecko.rs, components/style/gecko_bindings/structs_release.rs, components/style/parser.rs
  • @emilio: components/style/gecko_bindings/bindings.rs, components/style/gecko_bindings/structs_debug.rs, ports/geckolib/glue.rs, components/style/build_gecko.rs, components/style/gecko_bindings/structs_release.rs, components/style/parser.rs
@highfive
Copy link

highfive commented Mar 9, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@Manishearth
Copy link
Member Author

Manishearth commented Mar 9, 2017

@bors-servo r=bz
@bors-servo
Copy link
Contributor

bors-servo commented Mar 9, 2017

📌 Commit cafdfd2 has been approved by bz
@bors-servo
Copy link
Contributor

bors-servo commented Mar 9, 2017

⌛ Testing commit cafdfd2 with merge 3776564...
bors-servo added a commit that referenced this pull request Mar 9, 2017
@bors-servo
Auto merge of #15893 - Manishearth:stylo-svg-pres, r=bz
Loading status checks…
3776564 
Support SVG presentation attributes

r=bz from https://bugzilla.mozilla.org/show_bug.cgi?id=1329093

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15893)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 9, 2017

💔 Test failed - linux-dev
@Manishearth
stylo: Pass parser URL data in Servo_DeclarationBlock_SetProperty*
Loading status checks…
eda6a4f 
MozReview-Commit-ID: EVk4aEoyiXv
@Manishearth Manishearth force-pushed the Manishearth:stylo-svg-pres branch from cafdfd2 to eda6a4f Mar 9, 2017
@Manishearth
Copy link
Member Author

Manishearth commented Mar 9, 2017

@bors-servo r=bz
@bors-servo
Copy link
Contributor

bors-servo commented Mar 9, 2017

📌 Commit eda6a4f has been approved by bz
@bors-servo
Copy link
Contributor

bors-servo commented Mar 9, 2017

⌛ Testing commit eda6a4f with merge ee22379...
bors-servo added a commit that referenced this pull request Mar 9, 2017
@bors-servo
Auto merge of #15893 - Manishearth:stylo-svg-pres, r=bz
Loading status checks…
ee22379 
Support SVG presentation attributes

r=bz from https://bugzilla.mozilla.org/show_bug.cgi?id=1329093

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15893)
<!-- Reviewable:end -->
@bors-servo bors-servo mentioned this pull request Mar 9, 2017
Merged
4 of 4 tasks complete
@bors-servo
Copy link
Contributor

bors-servo commented Mar 9, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: bz
Pushing ee22379 to master...
@bors-servo bors-servo merged commit eda6a4f into servo:master Mar 9, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Manishearth Manishearth deleted the Manishearth:stylo-svg-pres branch Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@metajack metajack

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@Manishearth @highfive @bors-servo @metajack
You can’t perform that action at this time.