Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all DOM types from @mut to JSManaged. #1591

Merged
merged 1 commit into from Feb 24, 2014
Merged

Conversation

@jdm
Copy link
Member

jdm commented Jan 30, 2014

No description provided.

@highfive
Copy link

highfive commented Jan 30, 2014

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify layout code, but no reftests are modified. Please consider adding a reftest!
  • @jdm, please confirm that src/test/html/acid1.html and your favourite wikipedia page still render correctly!
@jdm
Copy link
Member Author

jdm commented Jan 30, 2014

Still to do:

  • Rebase
  • Address bikesheds - JSManaged -> JS, from/to -> up/down, value/mut_value -> get/get_mut
@pcwalton
Copy link
Contributor

pcwalton commented Jan 30, 2014

This is awesome. 🤘

@Ms2ger Ms2ger closed this Jan 30, 2014
@Ms2ger Ms2ger reopened this Jan 30, 2014
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jan 30, 2014

Critic review: https://critic.hoppipolla.co.uk/r/684

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jdm
Copy link
Member Author

jdm commented Feb 22, 2014

@kmcallister If you can sign off on my changes relating to the UnsafeFlow/PaddedUnsafeFlow stuff, this is basically ready to land after a final rebase.

@jdm

This comment has been minimized.

Copy link
Owner Author

jdm commented on 6253254 Feb 24, 2014

r=Ms2ger,kmcallister

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 6253254 Feb 24, 2014

saw approval from Ms2ger
at jdm@6253254

This comment has been minimized.

Copy link
Contributor

bors-servo replied Feb 24, 2014

merging jdm/servo/jsmanaged = 6253254 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Feb 24, 2014

jdm/servo/jsmanaged = 6253254 merged ok, testing candidate = ffcf3b2

This comment has been minimized.

Copy link
Contributor

bors-servo replied Feb 24, 2014

fast-forwarding master to auto = ffcf3b2

bors-servo pushed a commit that referenced this pull request Feb 24, 2014
@bors-servo bors-servo merged commit 6253254 into servo:master Feb 24, 2014
1 check passed
1 check passed
default all tests passed
@jdm jdm deleted the jdm:jsmanaged branch Aug 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.