Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to rustc 1.17.0-nightly (8c72b7651 2017-03-11) #15911

Merged
merged 1 commit into from Mar 11, 2017
Merged

Update to rustc 1.17.0-nightly (8c72b7651 2017-03-11) #15911

merged 1 commit into from Mar 11, 2017
+9 −9

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Mar 11, 2017 •
edited by larsbergstrom

This fixes the DOM node size regression introduced by a previous Rust update: #15704

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@SimonSapin
Update to rustc 1.17.0-nightly (8c72b7651 2017-03-11)
Loading status checks…
31678b4 
This fixes the DOM node size regression introduced by a previous Rust update:
#15704
@SimonSapin
Copy link
Member Author

SimonSapin commented Mar 11, 2017

@nox r?
@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Mar 11, 2017

⌛ Trying commit 31678b4 with merge 9d8da8d...
bors-servo added a commit that referenced this pull request Mar 11, 2017
@bors-servo
Auto merge of #15911 - servo:rustup_, r=<try>
Loading status checks…
9d8da8d 
Update to rustc 1.17.0-nightly (8c72b7651 2017-03-11)

This fixes the DOM node size regression introduced by a previous Rust update: #15704

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15911)
<!-- Reviewable:end -->
@SimonSapin SimonSapin mentioned this pull request Mar 11, 2017
Closed
@emilio
Copy link
Member

emilio commented Mar 11, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 11, 2017

📌 Commit 31678b4 has been approved by emilio
@highfive highfive assigned emilio and unassigned wafflespeanut Mar 11, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Mar 11, 2017

💔 Test failed - mac-dev-unit
@emilio
Copy link
Member

emilio commented Mar 11, 2017

@bors-servo retry

  • Generic exception
@bors-servo
Copy link
Contributor

bors-servo commented Mar 11, 2017

⌛ Testing commit 31678b4 with merge e102577...
bors-servo added a commit that referenced this pull request Mar 11, 2017
@bors-servo
Auto merge of #15911 - servo:rustup_, r=emilio
Loading status checks…
e102577 
Update to rustc 1.17.0-nightly (8c72b7651 2017-03-11)

This fixes the DOM node size regression introduced by a previous Rust update: #15704

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15911)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 11, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: emilio
Pushing e102577 to master...
@bors-servo bors-servo merged commit 31678b4 into master Mar 11, 2017
4 checks passed
4 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Mar 11, 2017
Closed
2 of 5 tasks complete
@MortimerGoro MortimerGoro mentioned this pull request Mar 11, 2017
Merged
4 of 5 tasks complete
@SimonSapin
Copy link
Member Author

SimonSapin commented Mar 11, 2017

The exception was:

File "/home/servo/buildbot/master/factories.py", line 40, in run
got_rev, rev
exceptions.Exception: Actual commit (5b0bb6b) differs from requested commit (9d8da8d)

@nox, this looks like a buildbot bug (?) you showed me on another issue recently. Did you find out what caused it?
@SimonSapin SimonSapin deleted the rustup_ branch Mar 11, 2017
@aneeshusa
Copy link
Member

aneeshusa commented Mar 20, 2017

@SimonSapin, this is a check I added to saltfs because Buildbot will silently fail to checkout the right commit and instead build + test an unrelated commit. It stops the build if it detects this has occurred; the best remediation for now is just to try the build again. Please submit a PR if you have a suggestion for a better error message!
@SimonSapin
Copy link
Member Author

SimonSapin commented Mar 20, 2017

@aneeshusa Thanks for adding this check. Indeed the build should be marked as unsuccessful when that happens. My question was, how can it happen in the first place?
@aneeshusa
Copy link
Member

aneeshusa commented Mar 20, 2017

The Git step built in to Buildbot is buggy. We have retryFetch=True since our build machines have trouble git fetching often. In the Buildbot source, this causes the builder to retry the fetch a second time. However, on both runs, abandonOnFailure is set to False for the git reset command which checks out the new commit since we have retryFetch=True (source). This appears to cause the silent error masking, and in my opinion, abandonOnFailure should be forced to True on the retry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@SimonSapin @bors-servo @emilio @aneeshusa @highfive @wafflespeanut
You can’t perform that action at this time.