Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: Support system colors #15974

Merged
merged 1 commit into from Mar 16, 2017
Merged

stylo: Support system colors #15974

merged 1 commit into from Mar 16, 2017

Conversation

@Manishearth
Copy link
Member

Manishearth commented Mar 16, 2017 •
edited by larsbergstrom

r=heycam from https://bugzilla.mozilla.org/show_bug.cgi?id=1340696

This change is Reviewable
@highfive
Copy link

highfive commented Mar 16, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko_bindings/bindings.rs, components/style/values/specified/color.rs, components/style/gecko_bindings/structs_debug.rs, components/style/build_gecko.rs, components/style/gecko_bindings/structs_release.rs, components/style/values/computed/mod.rs, components/style/properties/longhand/color.mako.rs
  • @emilio: components/style/gecko_bindings/bindings.rs, components/style/values/specified/color.rs, components/style/gecko_bindings/structs_debug.rs, components/style/build_gecko.rs, components/style/gecko_bindings/structs_release.rs, components/style/values/computed/mod.rs, components/style/properties/longhand/color.mako.rs
@highfive
Copy link

highfive commented Mar 16, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@Manishearth
Copy link
Member Author

Manishearth commented Mar 16, 2017

@bors-servo r=heycam
@bors-servo
Copy link
Contributor

bors-servo commented Mar 16, 2017

📌 Commit ade5f21 has been approved by heycam
@highfive highfive assigned heycam and unassigned pcwalton Mar 16, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Mar 16, 2017

⌛ Testing commit ade5f21 with merge eb536a8...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 16, 2017

💔 Test failed - linux-dev
@Manishearth
stylo: Support system colors
Loading status checks…
6b9a680 
MozReview-Commit-ID: HUfTdcMRoEx
@Manishearth Manishearth force-pushed the Manishearth:stylo-system-colors branch from ade5f21 to 6b9a680 Mar 16, 2017
@Manishearth
Copy link
Member Author

Manishearth commented Mar 16, 2017

@bors-servo r=heycam
@bors-servo
Copy link
Contributor

bors-servo commented Mar 16, 2017

📌 Commit 6b9a680 has been approved by heycam
@bors-servo
Copy link
Contributor

bors-servo commented Mar 16, 2017

⌛ Testing commit 6b9a680 with merge 261a51a...
bors-servo added a commit that referenced this pull request Mar 16, 2017
@bors-servo
Auto merge of #15974 - Manishearth:stylo-system-colors, r=heycam
Loading status checks…
261a51a 
stylo: Support system colors

r=heycam from https://bugzilla.mozilla.org/show_bug.cgi?id=1340696

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15974)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 16, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: heycam
Pushing 261a51a to master...
@bors-servo bors-servo merged commit 6b9a680 into servo:master Mar 16, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@emilio
emilio reviewed Mar 16, 2017
View changes
components/style/properties/longhand/color.mako.rs
];

let ident = input.expect_ident()?;
for &(name, color) in PARSE_ARRAY.iter() {

This comment has been minimized.

Sign in to view
Copy link
@emilio

emilio Mar 16, 2017

Member

don't we have a case_insensitive_phf_map thing just for this?

This comment has been minimized.

Sign in to view
Copy link
@Manishearth

Manishearth Mar 16, 2017

Author Member

Yes, but I'm not sure if it's worth it for a small list like this.

This comment has been minimized.

Sign in to view
Copy link
@emilio

emilio Mar 16, 2017

Member

I believe it's worth to be consistent. And case_insensitive_phf_map shouldn't be slower or anything.

This comment has been minimized.

Sign in to view
Copy link
@Manishearth

Manishearth Mar 16, 2017

Author Member

Works for me.

This comment has been minimized.

Sign in to view
Copy link
@Manishearth

Manishearth Mar 16, 2017

Author Member

filed #15994
@Manishearth Manishearth mentioned this pull request Mar 16, 2017
Open
@Manishearth Manishearth deleted the Manishearth:stylo-system-colors branch Mar 16, 2017
@Manishearth Manishearth mentioned this pull request Mar 16, 2017
Closed
@SergeevPavel SergeevPavel mentioned this pull request Jul 17, 2017
Merged
3 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio

Assignees

@heycam heycam

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@Manishearth @highfive @bors-servo @emilio @pcwalton @heycam
You can’t perform that action at this time.