Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-process lock for CSSOM objects #16014

Merged
merged 17 commits into from Mar 19, 2017
Merged

Per-process lock for CSSOM objects #16014

merged 17 commits into from Mar 19, 2017
+1,469 −912

Commits on Mar 19, 2017

  1. Add SharedRwLock<T> and Locked<T>

    @SimonSapin
    SimonSapin committed Mar 19, 2017
    8feb9e8

  2. Replace RwLock<MediaList> with shared_lock::Locked<MediaList>

    @SimonSapin
    SimonSapin committed Mar 19, 2017
    c5a7294

  3. Move shared lock acquires up the call stack. (Or is it down?)

    @SimonSapin
    SimonSapin committed Mar 19, 2017
    d18b128

  4. More lock acquire in callers

    @SimonSapin
    SimonSapin committed Mar 19, 2017
    3ae2ecb

  5. Introduce a ToCssWithGuard trait

    @SimonSapin
    SimonSapin committed Mar 19, 2017
    fe4e70c

  6. Replace more RwLock<MediaList> with shared_lock::Locked<MediaList>

    @SimonSapin
    SimonSapin committed Mar 19, 2017
    600152b

  7. Tidy

    @SimonSapin
    SimonSapin committed Mar 19, 2017
    b213daa

  8. Replace RwLock<CssRules> with Locked<CssRules>

    @SimonSapin
    SimonSapin committed Mar 19, 2017
    f35b4e2

  9. Wrap most CSS rules in Locked<_> instead of RwLock<_>

    @SimonSapin
    SimonSapin committed Mar 19, 2017
    adb97d4

  10. Replace RwLock<Keyframe> with Locked<Keyframe>

    @SimonSapin
    SimonSapin committed Mar 19, 2017
    57724e5

  11. Replace RwLock<StyleRule> with Locked<StyleRule>

    @SimonSapin
    SimonSapin committed Mar 19, 2017
    aeffca2

  12. Move all PropertyDeclarationBlock from RwLock<_> to Locked<_>

    @SimonSapin
    SimonSapin committed Mar 19, 2017
    1bacd0e

  13. Refactor StylesheetLoader so impls do not need to acquire a shared lock. 

    This fixes a deadlock:
#16014 (comment)
    @SimonSapin
    SimonSapin committed Mar 19, 2017
    1e38013

  14. Remove some indirection.

    @SimonSapin
    SimonSapin committed Mar 19, 2017
    cc04630

  15. Parse stylesheets without acquiring a shared lock.

    @SimonSapin
    SimonSapin committed Mar 19, 2017
    d949118

  16. Fix another deadlock

    @SimonSapin
    SimonSapin committed Mar 19, 2017
    2952ccf

  17. Rename ReadGuards to StylesheetGuards

    @SimonSapin
    SimonSapin committed Mar 19, 2017
    Loading status checks…
    d507413
You can’t perform that action at this time.