Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylo: Add support for text-size-adjust property #16036

Merged
merged 1 commit into from Mar 20, 2017

Conversation

chenpighead
Copy link
Contributor

@chenpighead chenpighead commented Mar 20, 2017

Gecko supports -{moz,webkit}-text-size-adjust properties, but it only supports auto and none value.
Implement parsing/serialization for text-size-adjust property and its gecko glue.


  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/inherited_text.mako.rs, components/style/properties/gecko.mako.rs
  • @emilio: components/style/properties/longhand/inherited_text.mako.rs, components/style/properties/gecko.mako.rs

@highfive
Copy link

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 20, 2017
@chenpighead
Copy link
Contributor Author

@bors-servo r=xidorn

@bors-servo
Copy link
Contributor

@chenpighead: 🔑 Insufficient privileges: Not in reviewers

@chenpighead
Copy link
Contributor Author

@bors-servo r=upsuper

@bors-servo
Copy link
Contributor

@chenpighead: 🔑 Insufficient privileges: Not in reviewers

@highfive highfive assigned upsuper and unassigned mbrubeck Mar 20, 2017
@upsuper
Copy link
Contributor

upsuper commented Mar 20, 2017

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 615c8cb has been approved by upsuper

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 20, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 615c8cb with merge 103e827...

bors-servo pushed a commit that referenced this pull request Mar 20, 2017
Stylo: Add support for text-size-adjust property

<!-- Please describe your changes on the following line: -->

Gecko supports -{moz,webkit}-text-size-adjust properties, but it only supports auto and none value.
Implement parsing/serialization for text-size-adjust property and its gecko glue.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #16002 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16036)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: upsuper
Pushing 103e827 to master...

@bors-servo bors-servo merged commit 615c8cb into servo:master Mar 20, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for text-size-adjust property
5 participants