Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WR (gl trait, scroll roots) #16073

Merged
merged 2 commits into from Mar 23, 2017
Merged

Update WR (gl trait, scroll roots) #16073

merged 2 commits into from Mar 23, 2017
+386 −338

Conversation

@glennw
Copy link
Member

glennw commented Mar 22, 2017 •
edited by larsbergstrom

This change is Reviewable
@mrobinson @gw3583
Stop splitting scroll roots
9d72e89 
Now that WebRender can handle splitting scrolling layers on its own, we
don't need to do any work to split up scroll roots. This should also
make it possible to handle overflow:scroll and containing block scroll
roots in the future.
@highfive
Copy link

highfive commented Mar 22, 2017

Heads up! This PR modifies the following files:

  • @asajeffrey: components/constellation/Cargo.toml
  • @KiChjang: components/script/Cargo.toml, components/script_traits/Cargo.toml, components/script_traits/Cargo.toml
  • @fitzgen: components/script/Cargo.toml, components/script_traits/Cargo.toml, components/script_traits/Cargo.toml
  • @emilio: components/layout/block.rs, components/canvas/webgl_paint_thread.rs, components/layout/webrender_helpers.rs, components/layout/display_list_builder.rs
@highfive
Copy link

highfive commented Mar 22, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify gfx, layout, and script code, but no tests are modified. Please consider adding a test!
@glennw
Copy link
Member Author

glennw commented Mar 22, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Mar 22, 2017

⌛ Trying commit 3eb8720 with merge 4ba0e34...
bors-servo added a commit that referenced this pull request Mar 22, 2017
@bors-servo
Auto merge of #16073 - glennw:update-wr-glfns, r=<try>
Loading status checks…
4ba0e34 
Update WR (gl trait, scroll roots)
@bors-servo
Copy link
Contributor

bors-servo commented Mar 22, 2017

💔 Test failed - android
@glennw glennw force-pushed the glennw:update-wr-glfns branch from 3eb8720 to ef3554d Mar 22, 2017
@glennw
Copy link
Member Author

glennw commented Mar 22, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Mar 22, 2017

⌛ Trying commit ef3554d with merge 3e47f6d...
bors-servo added a commit that referenced this pull request Mar 22, 2017
@bors-servo
Auto merge of #16073 - glennw:update-wr-glfns, r=<try>
Loading status checks…
3e47f6d 
Update WR (gl trait, scroll roots)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16073)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 22, 2017

💔 Test failed - android
@glennw glennw force-pushed the glennw:update-wr-glfns branch from ef3554d to e258dc7 Mar 22, 2017
@glennw
Copy link
Member Author

glennw commented Mar 22, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Mar 22, 2017

⌛ Trying commit e258dc7 with merge 2fbb4e3...
bors-servo added a commit that referenced this pull request Mar 22, 2017
@bors-servo
Auto merge of #16073 - glennw:update-wr-glfns, r=<try>
Loading status checks…
2fbb4e3 
Update WR (gl trait, scroll roots)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16073)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 22, 2017

💔 Test failed - android
@glennw glennw force-pushed the glennw:update-wr-glfns branch from e258dc7 to f6ace1e Mar 22, 2017
@glennw
Copy link
Member Author

glennw commented Mar 22, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Mar 22, 2017

⌛ Trying commit f6ace1e with merge ea5062f...
bors-servo added a commit that referenced this pull request Mar 22, 2017
@bors-servo
Auto merge of #16073 - glennw:update-wr-glfns, r=<try>
Loading status checks…
ea5062f 
Update WR (gl trait, scroll roots)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16073)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 22, 2017

💔 Test failed - android
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
State: approved= try=True
@glennw
Copy link
Member Author

glennw commented Mar 23, 2017

Try run succeeded - the code changes have been signed off by @emilio - so justs needs someone to sign off on the test expectation changes.
@mrobinson
Copy link
Member

mrobinson commented Mar 23, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

📌 Commit fe75382 has been approved by mrobinson
@highfive highfive assigned mrobinson and unassigned emilio Mar 23, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

⌛ Testing commit fe75382 with merge 7f352be...
bors-servo added a commit that referenced this pull request Mar 23, 2017
@bors-servo
Auto merge of #16073 - glennw:update-wr-glfns, r=mrobinson
Loading status checks…
7f352be 
Update WR (gl trait, scroll roots)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16073)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

💔 Test failed - mac-rel-wpt1
@emilio
Copy link
Member

emilio commented Mar 23, 2017

@bors-servo retry #14323
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

⌛ Testing commit fe75382 with merge c99289a...
bors-servo added a commit that referenced this pull request Mar 23, 2017
@bors-servo
Auto merge of #16073 - glennw:update-wr-glfns, r=mrobinson
Loading status checks…
c99289a 
Update WR (gl trait, scroll roots)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16073)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

💔 Test failed - mac-rel-wpt1
@emilio
Copy link
Member

emilio commented Mar 23, 2017

@bors-servo retry #14323
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt2, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt1...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: mrobinson
Pushing c99289a to master...
@bors-servo bors-servo merged commit fe75382 into servo:master Mar 23, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced Mar 23, 2017
Merged
Closed
Merged
@mrobinson mrobinson mentioned this pull request Mar 23, 2017
Closed
@glennw glennw deleted the glennw:update-wr-glfns branch Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio

Assignees

@mrobinson mrobinson

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
@glennw @highfive @bors-servo @jdm @mrobinson @emilio @Manishearth @gw3583
You can’t perform that action at this time.