Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement :required/:optional support for stylo. #16090

Merged
merged 1 commit into from Mar 23, 2017

Conversation

Projects
None yet
6 participants
@bzbarsky
Copy link
Contributor

commented Mar 23, 2017

Servo side of https://bugzilla.mozilla.org/show_bug.cgi?id=1349659


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Mar 23, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/wrapper.rs, components/style/element_state.rs, components/style/gecko/non_ts_pseudo_class_list.rs
  • @emilio: components/style/gecko/wrapper.rs, components/style/element_state.rs, components/style/gecko/non_ts_pseudo_class_list.rs
@highfive

This comment has been minimized.

Copy link

commented Mar 23, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@bzbarsky

This comment has been minimized.

Copy link
Contributor Author

commented Mar 23, 2017

r=emilio

@KiChjang

This comment has been minimized.

Copy link
Member

commented Mar 23, 2017

@bors-servo r=emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 23, 2017

📌 Commit 5a5a6cd has been approved by emilio

@highfive highfive assigned emilio and unassigned Ms2ger Mar 23, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 23, 2017

⌛️ Testing commit 5a5a6cd with merge 2124220...

bors-servo added a commit that referenced this pull request Mar 23, 2017

Auto merge of #16090 - bzbarsky:required-optional, r=emilio
Implement :required/:optional support for stylo.

Servo side of https://bugzilla.mozilla.org/show_bug.cgi?id=1349659

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16090)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 23, 2017

💔 Test failed - mac-rel-wpt1

@bzbarsky

This comment has been minimized.

Copy link
Contributor Author

commented Mar 23, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 23, 2017

⚡️ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt2, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt1...

@bzbarsky

This comment has been minimized.

Copy link
Contributor Author

commented Mar 23, 2017

Looks like that failure was due to #14323.

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 23, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: emilio
Pushing 2124220 to master...

@bors-servo bors-servo merged commit 5a5a6cd into servo:master Mar 23, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@bzbarsky bzbarsky deleted the bzbarsky:required-optional branch May 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.