Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle URLs more efficiently in stylo #16092

Merged
merged 2 commits into from Mar 23, 2017
Merged

Handle URLs more efficiently in stylo #16092

merged 2 commits into from Mar 23, 2017
+658 −683

Conversation

@bholley
Copy link
Contributor

bholley commented Mar 23, 2017 •
edited by larsbergstrom

Approved in https://bugzilla.mozilla.org/show_bug.cgi?id=1347435

This change is Reviewable
@bholley
Use a wrapper class to maintain the mBinding invariant and stop resol…
16e0404 
…ving during the cascade.
@highfive
Copy link

highfive commented Mar 23, 2017

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/element.rs
  • @fitzgen: components/script/dom/element.rs
  • @emilio: components/style/gecko_bindings/bindings.rs, components/style/gecko/url.rs, components/style/gecko_bindings/structs_debug.rs, components/style/build_gecko.rs, components/style/gecko_bindings/structs_release.rs, components/style/servo/url.rs, components/style/gecko/mod.rs, components/style/stylesheets.rs, components/style/properties/gecko.mako.rs, components/style/values/computed/mod.rs, components/style/servo/mod.rs, components/style/values/specified/url.rs, ports/geckolib/stylesheet_loader.rs, components/style/values/specified/mod.rs, components/style/properties/longhand/svg.mako.rs, components/style/values/specified/image.rs
@highfive
Copy link

highfive commented Mar 23, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style and script code, but no tests are modified. Please consider adding a test!
@bholley
Copy link
Contributor Author

bholley commented Mar 23, 2017

@bors-servo r=emilio p=10
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

📌 Commit 4be4df6 has been approved by emilio
@highfive highfive assigned emilio and unassigned pcwalton Mar 23, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

⌛ Testing commit 4be4df6 with merge ebe3930...
bors-servo added a commit that referenced this pull request Mar 23, 2017
@bors-servo
Auto merge of #16092 - bholley:specified_urls, r=emilio
Loading status checks…
ebe3930 
Handle URLs more efficiently in stylo

Approved in https://bugzilla.mozilla.org/show_bug.cgi?id=1347435

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16092)
<!-- Reviewable:end -->
@bholley
Copy link
Contributor Author

bholley commented Mar 23, 2017

@bors-servo r-

Mismerge
@bholley bholley force-pushed the bholley:specified_urls branch from 4be4df6 to a5cc36a Mar 23, 2017
@bholley
Copy link
Contributor Author

bholley commented Mar 23, 2017

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

📌 Commit a5cc36a has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

⌛ Testing commit a5cc36a with merge ca04696...
bors-servo added a commit that referenced this pull request Mar 23, 2017
@bors-servo
Auto merge of #16092 - bholley:specified_urls, r=emilio
Loading status checks…
ca04696 
Handle URLs more efficiently in stylo

Approved in https://bugzilla.mozilla.org/show_bug.cgi?id=1347435

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16092)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

💔 Test failed - linux-dev
@bholley
Don't resolve URLs at parse time for Stylo.
Loading status checks…
63e8367 
It's a bit unfortunate the use separate implementations of SpecifiedUrl for Servo
and Gecko, but they're different enough at this point that I don't think it really
makes sense to try to share everything. Splitting them out has some nice
simplifications as well.

I recognize that there's still some potential correctness issues for Servo using
the resolved URI in various places where the original URI may be the right thing,
but I've got too much on my plate to look into that for now.

MozReview-Commit-ID: BeDu93TQ4Ow
@bholley bholley force-pushed the bholley:specified_urls branch from a5cc36a to 63e8367 Mar 23, 2017
@bholley
Copy link
Contributor Author

bholley commented Mar 23, 2017

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

📌 Commit 63e8367 has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

⌛ Testing commit 63e8367 with merge d4d8293...
bors-servo added a commit that referenced this pull request Mar 23, 2017
@bors-servo
Auto merge of #16092 - bholley:specified_urls, r=emilio
Loading status checks…
d4d8293 
Handle URLs more efficiently in stylo

Approved in https://bugzilla.mozilla.org/show_bug.cgi?id=1347435

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16092)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

💔 Test failed - mac-rel-wpt1
@bholley
Copy link
Contributor Author

bholley commented Mar 23, 2017

@bors-servo retry #14323
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

⚡ Previous build results for android, arm32, arm64, linux-rel-css, mac-dev-unit, windows-msvc-dev are reusable. Rebuilding only linux-dev, linux-rel-wpt, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: emilio
Pushing d4d8293 to master...
@bors-servo bors-servo merged commit 63e8367 into servo:master Mar 23, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@bholley @highfive @bors-servo @pcwalton @emilio
You can’t perform that action at this time.