Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle URLs more efficiently in stylo #16092

Merged
merged 2 commits into from Mar 23, 2017
Merged

Handle URLs more efficiently in stylo #16092

merged 2 commits into from Mar 23, 2017
+658 −683

Commits on Mar 23, 2017

  1. Use a wrapper class to maintain the mBinding invariant and stop resol… 

    …ving during the cascade.
    @bholley
    bholley committed Mar 23, 2017
    16e0404

  2. Don't resolve URLs at parse time for Stylo. 

    It's a bit unfortunate the use separate implementations of SpecifiedUrl for Servo
and Gecko, but they're different enough at this point that I don't think it really
makes sense to try to share everything. Splitting them out has some nice
simplifications as well.

I recognize that there's still some potential correctness issues for Servo using
the resolved URI in various places where the original URI may be the right thing,
but I've got too much on my plate to look into that for now.

MozReview-Commit-ID: BeDu93TQ4Ow
    @bholley
    bholley committed Mar 23, 2017
    Loading status checks…
    63e8367
You can’t perform that action at this time.