Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1349553: Account for negations of state-dependent selectors. #16093

Merged
merged 2 commits into from Mar 23, 2017
Merged

Bug 1349553: Account for negations of state-dependent selectors. #16093

merged 2 commits into from Mar 23, 2017
+22 −1

Conversation

@emilio
Copy link
Member

emilio commented Mar 23, 2017 •
edited by larsbergstrom

This change is Reviewable
emilio added 2 commits Mar 22, 2017
@emilio
Bug 1349553: Add a bit of debugging information to the preprocess_chi…
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
2b99c76 
…ldren stage.

MozReview-Commit-ID: 7zv62MRX8dE
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
@emilio
Bug 1349553: Account for negations of state-dependent selectors.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
ab2956a 
MozReview-Commit-ID: VyHuxh9q5N
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
@highfive
Copy link

highfive commented Mar 23, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/restyle_hints.rs, components/style/gecko/selector_parser.rs, components/style/traversal.rs
@highfive
Copy link

highfive commented Mar 23, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member Author

emilio commented Mar 23, 2017

@bors-servo r=bholley,heycam p=1

  • Needs test updates in m-c
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

📌 Commit ab2956a has been approved by bholley,heycam
@highfive highfive assigned bholley and unassigned cbrewster Mar 23, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

⌛ Testing commit ab2956a with merge 301ba36...
bors-servo added a commit that referenced this pull request Mar 23, 2017
@bors-servo
Auto merge of #16093 - emilio:state, r=bholley,heycam
Loading status checks…
301ba36 
Bug 1349553: Account for negations of state-dependent selectors.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

💔 Test failed - mac-rel-wpt1
@emilio
Copy link
Member Author

emilio commented Mar 23, 2017

@bors-servo retry #14323
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt2, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt1...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: bholley,heycam
Pushing 301ba36 to master...
@bors-servo bors-servo merged commit ab2956a into servo:master Mar 23, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@emilio emilio deleted the emilio:state branch Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bholley bholley

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@emilio @highfive @bors-servo @bholley @cbrewster
You can’t perform that action at this time.