Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1349885: stylo: Simplify computation of float and position. #16094

Merged
merged 1 commit into from Mar 23, 2017
Merged

Bug 1349885: stylo: Simplify computation of float and position. #16094

merged 1 commit into from Mar 23, 2017
+34 −59

Conversation

@emilio
Copy link
Member

emilio commented Mar 23, 2017 •
edited by larsbergstrom

This change is Reviewable
@highfive
Copy link

highfive commented Mar 23, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/box.mako.rs, components/style/properties/properties.mako.rs
@highfive
Copy link

highfive commented Mar 23, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member Author

emilio commented Mar 23, 2017

@bors-servo r=heycam,upsuper
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

📌 Commit e0852ae has been approved by heycam,upsuper
@highfive highfive assigned heycam and unassigned glennw Mar 23, 2017
@emilio
Bug 1349885: stylo: Simplify computation of float and position. r=hey…
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
c8e0542 
…cam,xidorn

MozReview-Commit-ID: Hh6391DXV5o
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
@emilio emilio force-pushed the emilio:simplify-float-pos branch from e0852ae to c8e0542 Mar 23, 2017
@emilio
Copy link
Member Author

emilio commented Mar 23, 2017

@bors-servo r=heycam,upsuper p=1

  • Allowed a warning for Servo.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

📌 Commit c8e0542 has been approved by heycam,upsuper
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

⌛ Testing commit c8e0542 with merge 9ba5bf7...
bors-servo added a commit that referenced this pull request Mar 23, 2017
@bors-servo
Auto merge of #16094 - emilio:simplify-float-pos, r=heycam,upsuper
Loading status checks…
9ba5bf7 
Bug 1349885: stylo: Simplify computation of float and position.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16094)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

💔 Test failed - mac-rel-wpt1
@emilio
Copy link
Member Author

emilio commented Mar 23, 2017

@bors-servo retry #14323
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

⌛ Testing commit c8e0542 with merge 9d0b481...
bors-servo added a commit that referenced this pull request Mar 23, 2017
@bors-servo
Auto merge of #16094 - emilio:simplify-float-pos, r=heycam,upsuper
Loading status checks…
9d0b481 
Bug 1349885: stylo: Simplify computation of float and position.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16094)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Mar 23, 2017

@bors-servo retry #14323
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt, mac-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: heycam,upsuper
Pushing 9d0b481 to master...
@bors-servo bors-servo merged commit c8e0542 into servo:master Mar 23, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@emilio emilio deleted the emilio:simplify-float-pos branch Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@heycam heycam

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@emilio @highfive @bors-servo @jdm @heycam @glennw
You can’t perform that action at this time.