Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request users to allow edits from maintainers in PRs #16102

Merged
merged 1 commit into from Mar 23, 2017

Conversation

@wafflespeanut
Copy link
Member

wafflespeanut commented Mar 23, 2017

Github auto-unchecks this checkbox once the PR has been opened. So, I'm not sure how useful this is gonna be, but it's worth mentioning anyway.


This change is Reviewable

@wafflespeanut wafflespeanut force-pushed the wafflespeanut:edits branch from ba1abf1 to 79ae438 Mar 23, 2017
@wafflespeanut
Copy link
Member Author

wafflespeanut commented Mar 23, 2017

@bors-servo r=jdm

@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

📌 Commit 79ae438 has been approved by jdm

@highfive highfive assigned jdm and unassigned nox Mar 23, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

Testing commit 79ae438 with merge c186fb2...

bors-servo added a commit that referenced this pull request Mar 23, 2017
Request users to allow edits from maintainers in PRs

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16102)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

💔 Test failed - mac-rel-wpt1

@wafflespeanut
Copy link
Member Author

wafflespeanut commented Mar 23, 2017

Ah, #14323 and all its glories!

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

Testing commit 79ae438 with merge 4838add...

bors-servo added a commit that referenced this pull request Mar 23, 2017
Request users to allow edits from maintainers in PRs

Github auto-unchecks this checkbox once the PR has been opened. So, I'm not sure how useful this is gonna be, but it's worth mentioning anyway.

---
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16102)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: jdm
Pushing 4838add to master...

@bors-servo bors-servo merged commit 79ae438 into servo:master Mar 23, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@wafflespeanut wafflespeanut deleted the wafflespeanut:edits branch Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.