Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1594 Rename element field of Text and Comment to characterdata #1611

Closed
wants to merge 2 commits into from

Conversation

@xiongmao86
Copy link
Contributor

xiongmao86 commented Feb 3, 2014

Rename element field of Text and Comment to characterdata.

@highfive
Copy link

highfive commented Feb 3, 2014

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @kmcallister (or someone else) soon.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Feb 3, 2014

Critic review: https://critic.hoppipolla.co.uk/r/708

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@highfive
Copy link

highfive commented Feb 3, 2014

warning Warning warning

  • These commits modify layout code, but no reftests are modified. Please consider adding a reftest!
  • @xiongmao86, please confirm that src/test/html/acid1.html and your favourite wikipedia page still render correctly!
@brson
Copy link
Contributor

brson commented Feb 5, 2014

Nice fixes! Thanks.

@Ms2ger
Copy link
Contributor

Ms2ger commented Feb 5, 2014

Unfortunately, this also includes #1610, so we can't land as-is. Please ping me when that has landed, so I can review.

@Ms2ger Ms2ger closed this Feb 5, 2014
@xiongmao86 xiongmao86 deleted the xiongmao86:issue1594 branch Feb 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.