Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'appearance' property to Stylo (with '-webkit-appearance' alias) #16110

Closed
wants to merge 1 commit into from
Closed

Add 'appearance' property to Stylo (with '-webkit-appearance' alias) #16110

wants to merge 1 commit into from

Conversation

@Manishearth
Copy link
Member

Manishearth commented Mar 23, 2017 •
edited by larsbergstrom

r=me from https://bugzilla.mozilla.org/show_bug.cgi?id=1333482

This change is Reviewable
@MatsPalmgren @Manishearth
Add 'appearance' property to Stylo (with '-webkit-appearance' alias)
Loading status checks…
0ec7365
@highfive
Copy link

highfive commented Mar 23, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/box.mako.rs
  • @emilio: components/style/properties/longhand/box.mako.rs
@highfive
Copy link

highfive commented Mar 23, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@Manishearth
Copy link
Member Author

Manishearth commented Mar 23, 2017

@bors-servo delegate=MatsPalmgren

Please use @ bors-servo r=Manishearth in a comment to land this PR
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2017

✌️ @MatsPalmgren can now approve this pull request
@bholley
Copy link
Contributor

bholley commented Mar 24, 2017

@bors-servo r=Manishearth p=10
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2017

📌 Commit 0ec7365 has been approved by Manishearth
@highfive highfive assigned Manishearth and unassigned mbrubeck Mar 24, 2017
@bholley
Copy link
Contributor

bholley commented Mar 24, 2017

Oh, looks like this is missing a checked-in binding update, and won't compile. :-(

@bors-servo r-
@bholley bholley mentioned this pull request Mar 24, 2017
Merged
@bholley
Copy link
Contributor

bholley commented Mar 24, 2017

I uploaded a new PR in #16112.
@bholley bholley closed this Mar 24, 2017
bors-servo added a commit that referenced this pull request Mar 24, 2017
@bors-servo
Auto merge of #16112 - bholley:mozappearance, r=Manishearth
Loading status checks…
3a898f4 
Add 'appearance' property to Stylo (with '-webkit-appearance' alias) (take 2)

Replacement for #16110.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16112)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Mar 24, 2017
@bors-servo
Auto merge of #16112 - bholley:mozappearance, r=Manishearth
Loading status checks…
30fc790 
Add 'appearance' property to Stylo (with '-webkit-appearance' alias) (take 2)

Replacement for #16110.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16112)
<!-- Reviewable:end -->
@Manishearth Manishearth deleted the Manishearth:mozappearance branch May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@Manishearth @highfive @bors-servo @bholley @mbrubeck @MatsPalmgren
You can’t perform that action at this time.