Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'appearance' property to Stylo (with '-webkit-appearance' alias) (take 2) #16112

Merged
merged 1 commit into from Mar 24, 2017
Merged

Add 'appearance' property to Stylo (with '-webkit-appearance' alias) (take 2) #16112

merged 1 commit into from Mar 24, 2017
+1,173 −1,123

Conversation

@bholley
Copy link
Contributor

bholley commented Mar 24, 2017 •
edited by larsbergstrom

Replacement for #16110.

This change is Reviewable
@highfive
Copy link

highfive commented Mar 24, 2017

Heads up! This PR modifies the following files:

  • @emilio: components/style/gecko_bindings/structs_debug.rs, components/style/properties/longhand/box.mako.rs, components/style/gecko_bindings/structs_release.rs
@highfive
Copy link

highfive commented Mar 24, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@bholley
Copy link
Contributor Author

bholley commented Mar 24, 2017

@bors-servo r=Manishearth p=10
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2017

📌 Commit e512656 has been approved by Manishearth
@highfive highfive assigned Manishearth and unassigned KiChjang Mar 24, 2017
@bholley bholley mentioned this pull request Mar 24, 2017
Closed
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2017

⌛ Testing commit e512656 with merge 3a898f4...
bors-servo added a commit that referenced this pull request Mar 24, 2017
@bors-servo
Auto merge of #16112 - bholley:mozappearance, r=Manishearth
Loading status checks…
3a898f4 
Add 'appearance' property to Stylo (with '-webkit-appearance' alias) (take 2)

Replacement for #16110.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16112)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2017

💔 Test failed - linux-dev
@jdm
Copy link
Member

jdm commented Mar 24, 2017

./components/style/properties/longhand/box.mako.rs:2020: Line is longer than 120 characters
@jdm jdm added the S-fails-tidy label Mar 24, 2017
@MatsPalmgren @bholley
Add 'appearance' property to Stylo (with '-webkit-appearance' alias)
Loading status checks…
2d2b989
@bholley bholley force-pushed the bholley:mozappearance branch from e512656 to 2d2b989 Mar 24, 2017
@bholley
Copy link
Contributor Author

bholley commented Mar 24, 2017

tiddddyyyy

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2017

📌 Commit 2d2b989 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2017

⌛ Testing commit 2d2b989 with merge 30fc790...
bors-servo added a commit that referenced this pull request Mar 24, 2017
@bors-servo
Auto merge of #16112 - bholley:mozappearance, r=Manishearth
Loading status checks…
30fc790 
Add 'appearance' property to Stylo (with '-webkit-appearance' alias) (take 2)

Replacement for #16110.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16112)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2017

💔 Test failed - mac-rel-wpt1
@bholley
Copy link
Contributor Author

bholley commented Mar 24, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, windows-msvc-dev are reusable. Rebuilding only linux-rel-css, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2...
@bholley
Copy link
Contributor Author

bholley commented Mar 24, 2017

#14323
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: Manishearth
Pushing 30fc790 to master...
@bors-servo bors-servo merged commit 2d2b989 into servo:master Mar 24, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
S-fails-tidy S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@bholley @highfive @bors-servo @jdm @Manishearth @KiChjang @MatsPalmgren
You can’t perform that action at this time.