Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upremove unused `use` statements in mako helpers #16121
Merged
+0
−2
Conversation
These are no longer needed, according to `./mach build -d` and grep.
highfive
commented
Mar 24, 2017
highfive
commented
Mar 24, 2017
|
|
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 24, 2017
remove unused `use` statements in mako helpers These are no longer needed, according to `./mach build -d` and grep. - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because compilation is sufficient <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16121) <!-- Reviewable:end -->
|
|
|
@bors-servo retry #14323 |
bors-servo
added a commit
that referenced
this pull request
Mar 25, 2017
remove unused `use` statements in mako helpers These are no longer needed, according to `./mach build -d` and grep. - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because compilation is sufficient <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16121) <!-- Reviewable:end -->
|
|
|
Meh, same thing. @bors-servo retry |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
froydnj commentedMar 24, 2017
•
edited by larsbergstrom
These are no longer needed, according to
./mach build -dand grep../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is