Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: Handle font-size keywords correctly #16122

Merged
merged 3 commits into from Mar 24, 2017
Merged

stylo: Handle font-size keywords correctly #16122

merged 3 commits into from Mar 24, 2017

Conversation

@Manishearth
Copy link
Member

Manishearth commented Mar 24, 2017 •
edited by larsbergstrom

r=heycam https://bugzilla.mozilla.org/show_bug.cgi?id=1341775

This change is Reviewable
Manishearth added 2 commits Mar 18, 2017
@Manishearth
stylo: Compute font-size between font-family and all late properties
0aceddd 
MozReview-Commit-ID: Ff6kt8RLChI
@Manishearth
stylo: Calculate font-size keywords based on base size
fddddc9 
MozReview-Commit-ID: Ff6kt8RLChI
@highfive
Copy link

highfive commented Mar 24, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko_bindings/bindings.rs, components/style/properties/gecko.mako.rs, components/style/gecko_bindings/structs_debug.rs, components/style/build_gecko.rs, components/style/gecko_bindings/structs_release.rs, components/style/properties/helpers.mako.rs, components/style/properties/longhand/font.mako.rs, components/style/values/specified/length.rs, components/style/properties/properties.mako.rs
  • @emilio: components/style/gecko_bindings/bindings.rs, components/style/properties/gecko.mako.rs, components/style/gecko_bindings/structs_debug.rs, components/style/build_gecko.rs, components/style/gecko_bindings/structs_release.rs, components/style/properties/helpers.mako.rs, components/style/properties/longhand/font.mako.rs, components/style/values/specified/length.rs, components/style/properties/properties.mako.rs
@highfive
Copy link

highfive commented Mar 24, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@Manishearth
Copy link
Member Author

Manishearth commented Mar 24, 2017

@bors-servo r=heycam p=2
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2017

📌 Commit af7e554 has been approved by heycam
@highfive highfive assigned heycam and unassigned mbrubeck Mar 24, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2017

⌛ Testing commit af7e554 with merge 80977e0...
bors-servo added a commit that referenced this pull request Mar 24, 2017
@bors-servo
Auto merge of #16122 - Manishearth:stylo-font-size, r=heycam
Loading status checks…
80977e0 
stylo: Handle font-size keywords correctly

r=heycam https://bugzilla.mozilla.org/show_bug.cgi?id=1341775
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2017

💔 Test failed - linux-dev
@Manishearth
stylo: Special-case initial-computation of font-size
Loading status checks…
3139a90 
MozReview-Commit-ID: Ff6kt8RLChI
@Manishearth Manishearth force-pushed the Manishearth:stylo-font-size branch from af7e554 to 3139a90 Mar 24, 2017
@Manishearth
Copy link
Member Author

Manishearth commented Mar 24, 2017

@bors-servo r=heycam
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2017

📌 Commit 3139a90 has been approved by heycam
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2017

⌛ Testing commit 3139a90 with merge fae6791...
bors-servo added a commit that referenced this pull request Mar 24, 2017
@bors-servo
Auto merge of #16122 - Manishearth:stylo-font-size, r=heycam
Loading status checks…
fae6791 
stylo: Handle font-size keywords correctly

r=heycam https://bugzilla.mozilla.org/show_bug.cgi?id=1341775

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16122)
<!-- Reviewable:end -->
@bors-servo bors-servo mentioned this pull request Mar 24, 2017
Merged
2 of 4 tasks complete
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2017

💔 Test failed - linux-rel-wpt
@Manishearth
Copy link
Member Author

Manishearth commented Mar 24, 2017

@bors-servo retry
@Manishearth Manishearth mentioned this pull request Mar 24, 2017
Open
@Manishearth
Copy link
Member Author

Manishearth commented Mar 24, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2017

⌛ Testing commit 3139a90 with merge 1584bbd...
bors-servo added a commit that referenced this pull request Mar 24, 2017
@bors-servo
Auto merge of #16122 - Manishearth:stylo-font-size, r=heycam
Loading status checks…
1584bbd 
stylo: Handle font-size keywords correctly

r=heycam https://bugzilla.mozilla.org/show_bug.cgi?id=1341775

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16122)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: heycam
Pushing 1584bbd to master...
@bors-servo bors-servo merged commit 3139a90 into servo:master Mar 24, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Manishearth Manishearth deleted the Manishearth:stylo-font-size branch Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@heycam heycam

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Manishearth @highfive @bors-servo @mbrubeck @heycam
You can’t perform that action at this time.