Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix writing-mode display fixup to check the right condition. #16123
Conversation
It should be checking the value of the 'writing-mode' property, not the value of the "writing mode" concept. The latter is influenced by other properties like 'direction' and whatnot. That was causing this code to convert inlines to inline-blocks if they just had a different direction from their parent, which is not correct
highfive
commented
Mar 24, 2017
highfive
commented
Mar 24, 2017
|
|
|
@bors-servo delegate+ It'd be nice to modify the test case introduced in #16044 to also test this, but since it's tested also in Gecko, feel free to just r=me if you don't have the time for it. |
|
|
|
@bors-servo r=emilio |
|
|
|
@bors-servo r=emilio p=10 |
|
|
|
Fix writing-mode display fixup to check the right condition. It should be checking the value of the 'writing-mode' property, not the value of the "writing mode" concept. The latter is influenced by other properties like 'direction' and whatnot. That was causing this code to convert inlines to inline-blocks if they just had a different direction from their parent, which is not correct <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because there are tons of tests on the Gecko side. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16123) <!-- Reviewable:end -->
|
|
bzbarsky commentedMar 24, 2017
•
edited by larsbergstrom
It should be checking the value of the 'writing-mode' property, not the value of
the "writing mode" concept. The latter is influenced by other properties like
'direction' and whatnot. That was causing this code to convert inlines to
inline-blocks if they just had a different direction from their parent, which is
not correct
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is