Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for -moz-image-rect #16133

Merged
merged 2 commits into from Mar 25, 2017

Conversation

@canaltinova
Copy link
Member

commented Mar 25, 2017

Add support for -moz-image-rect
r=Manishearth


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #15948 and Bug 1341763

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Mar 25, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko_bindings/bindings.rs, components/style/properties/gecko.mako.rs, components/style/values/specified/mod.rs, components/style/values/computed/mod.rs, components/style/gecko/conversions.rs, components/style/properties/longhand/border.mako.rs, components/style/values/specified/length.rs, components/style/values/specified/image.rs, components/style/values/computed/image.rs, components/style/gecko/values.rs
  • @emilio: components/style/gecko_bindings/bindings.rs, components/layout/display_list_builder.rs, components/style/properties/gecko.mako.rs, components/style/values/specified/mod.rs, components/style/values/computed/mod.rs, components/style/gecko/conversions.rs, components/style/properties/longhand/border.mako.rs, components/style/values/specified/length.rs, components/style/values/specified/image.rs, components/style/values/computed/image.rs, components/style/gecko/values.rs
@highfive

This comment has been minimized.

Copy link

commented Mar 25, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style and layout code, but no tests are modified. Please consider adding a test!
canaltinova added 2 commits Mar 24, 2017

@canaltinova canaltinova force-pushed the canaltinova:image-rect branch from c93e7ec to 494238a Mar 25, 2017

@canaltinova

This comment has been minimized.

Copy link
Member Author

commented Mar 25, 2017

@highfive highfive assigned Manishearth and unassigned asajeffrey Mar 25, 2017

@canaltinova

This comment has been minimized.

Copy link
Member Author

commented Mar 25, 2017

@bors-servo r=Manishearth

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2017

📌 Commit 494238a has been approved by Manishearth

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2017

⌛️ Testing commit 494238a with merge c2d9f66...

bors-servo added a commit that referenced this pull request Mar 25, 2017
Auto merge of #16133 - canaltinova:image-rect, r=Manishearth
Add support for -moz-image-rect

Add support for -moz-image-rect
r=Manishearth

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #15948 and [Bug 1341763](https://bugzilla.mozilla.org/show_bug.cgi?id=1341763)

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16133)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: Manishearth
Pushing c2d9f66 to master...

@bors-servo bors-servo merged commit 494238a into servo:master Mar 25, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.