Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Re-introduce the -webkit- prefix for the order property. #16151

Merged
merged 1 commit into from Mar 27, 2017
Merged

style: Re-introduce the -webkit- prefix for the order property. #16151

merged 1 commit into from Mar 27, 2017

Conversation

@emilio
Copy link
Member

emilio commented Mar 27, 2017 •
edited by larsbergstrom

I accidentally removed it while converting "order" to a predefined type
in #16144.

This change is Reviewable
@emilio
style: Re-introduce the -webkit- prefix for the order property.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
17f055c 
I accidentally removed it while converting "order" to a predefined type
in #16144.
@highfive
Copy link

highfive commented Mar 27, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/position.mako.rs
@highfive
Copy link

highfive commented Mar 27, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member Author

emilio commented Mar 27, 2017

@bors-servo r+ p=1

  • m-c is orange.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 27, 2017

📌 Commit 17f055c has been approved by emilio
@highfive highfive assigned emilio and unassigned jdm Mar 27, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Mar 27, 2017

⌛ Testing commit 17f055c with merge 185d31f...
bors-servo added a commit that referenced this pull request Mar 27, 2017
@bors-servo
Auto merge of #16151 - emilio:fixup-webkit-order, r=emilio
Loading status checks…
185d31f 
style: Re-introduce the -webkit- prefix for the order property.

I accidentally removed it while converting "order" to a predefined type
in #16144.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 27, 2017

💔 Test failed - linux-rel-css
@emilio
Copy link
Member Author

emilio commented Mar 27, 2017

@bors-servo retry #14237
@bors-servo
Copy link
Contributor

bors-servo commented Mar 27, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev are reusable. Rebuilding only linux-rel-css, mac-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 27, 2017

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Mar 27, 2017

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 27, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev are reusable. Rebuilding only linux-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 27, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: emilio
Pushing 185d31f to master...
@bors-servo bors-servo merged commit 17f055c into servo:master Mar 27, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@emilio emilio deleted the emilio:fixup-webkit-order branch Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@emilio @highfive @bors-servo @jdm
You can’t perform that action at this time.