Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some enhancements in the net crate #16160

Merged
merged 4 commits into from Mar 29, 2017
Merged

Some enhancements in the net crate #16160

merged 4 commits into from Mar 29, 2017

Conversation

@nox
Copy link
Member

nox commented Mar 27, 2017 •
edited by larsbergstrom

See the individual commits.

This change is Reviewable
nox added 4 commits Mar 27, 2017
@nox
Simplify should_be_blocked_due_to_nosniff
d64aa9c
@nox
Introduce http_loader::is_redirect_status
e2e2d42
@nox
Introduce create_ssl_context
7a4632b
@nox
Store SSL context in ResourceGroup
Loading status checks…
02b2aa1 
This allows sharing it with the HTTP state in CoreResourceManager::fetch.
@highfive
Copy link

highfive commented Mar 27, 2017

Heads up! This PR modifies the following files:

  • @KiChjang: components/net/resource_thread.rs, components/net/fetch/methods.rs, components/net/connector.rs, components/net/http_loader.rs
@highfive
Copy link

highfive commented Mar 27, 2017

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member Author

nox commented Mar 27, 2017

r? @jdm
@highfive highfive assigned jdm and unassigned cbrewster Mar 27, 2017
@jdm
Copy link
Member

jdm commented Mar 28, 2017

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 28, 2017

📌 Commit 02b2aa1 has been approved by jdm
@nox
Copy link
Member Author

nox commented Mar 28, 2017

@bors-servo retry force
@nox nox closed this Mar 28, 2017
@nox nox reopened this Mar 28, 2017
@nox
Copy link
Member Author

nox commented Mar 28, 2017

@bors-servo retry clean force
@Manishearth
Copy link
Member

Manishearth commented Mar 28, 2017

@bors-servo are you still there?
@bors-servo
Copy link
Contributor

bors-servo commented Mar 28, 2017

🍰 Activated
@Manishearth
Copy link
Member

Manishearth commented Mar 28, 2017

@bors-servo retry clean r- r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Mar 28, 2017

💡 This pull request was already approved, no need to approve it again.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 28, 2017

📌 Commit 02b2aa1 has been approved by jdm
@Manishearth
Copy link
Member

Manishearth commented Mar 28, 2017

@bors-servo retry clean
1 similar comment
@Manishearth
Copy link
Member

Manishearth commented Mar 28, 2017

@bors-servo retry clean
@Manishearth
Copy link
Member

Manishearth commented Mar 28, 2017

@bors-servo r- r=jdm retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 28, 2017

💡 This pull request was already approved, no need to approve it again.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 28, 2017

📌 Commit 02b2aa1 has been approved by jdm
@nox
Copy link
Member Author

nox commented Mar 28, 2017

@bors-servo p=2
@nox
Copy link
Member Author

nox commented Mar 28, 2017

@bors-servo retry #16172
@bors-servo
Copy link
Contributor

bors-servo commented Mar 28, 2017

⌛ Testing commit 02b2aa1 with merge dbaa9e4...
bors-servo added a commit that referenced this pull request Mar 28, 2017
@bors-servo
Auto merge of #16160 - nox:tungstenite, r=jdm
Loading status checks…
dbaa9e4 
Some enhancements in the net crate

See the individual commits.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16160)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 28, 2017

💔 Test failed - linux-rel-wpt
@nox
Copy link
Member Author

nox commented Mar 28, 2017

@bors-servo retry #14323
@bors-servo
Copy link
Contributor

bors-servo commented Mar 28, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 28, 2017

💔 Test failed - linux-rel-wpt
@bors-servo
Copy link
Contributor

bors-servo commented Mar 29, 2017

⌛ Testing commit 02b2aa1 with merge a9b7984f2b12fb78b1b100e8f858b3e9701a59ee...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 29, 2017

💔 Test failed - linux-rel-css
@nox
Copy link
Member Author

nox commented Mar 29, 2017

@bors-servo retry #14237
@bors-servo
Copy link
Contributor

bors-servo commented Mar 29, 2017

⌛ Testing commit 02b2aa1 with merge 299f944...
bors-servo added a commit that referenced this pull request Mar 29, 2017
@bors-servo
Auto merge of #16160 - nox:tungstenite, r=jdm
Loading status checks…
299f944 
Some enhancements in the net crate

See the individual commits.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16160)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 29, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: jdm
Pushing 299f944 to master...
@bors-servo bors-servo merged commit 02b2aa1 into servo:master Mar 29, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Mar 29, 2017
Merged
4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@nox @highfive @jdm @bors-servo @Manishearth @cbrewster
You can’t perform that action at this time.