Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: Get rid of one of the copies of the `expand` function. #16182

Closed
wants to merge 1 commit into from

Conversation

@emilio
Copy link
Member

emilio commented Mar 29, 2017

This change is Reviewable

@highfive
Copy link

highfive commented Mar 29, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/declaration_block.rs, components/style/properties/properties.mako.rs
@highfive
Copy link

highfive commented Mar 29, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member Author

emilio commented Mar 29, 2017

@highfive highfive assigned Manishearth and unassigned cbrewster Mar 29, 2017
@emilio emilio force-pushed the emilio:expand branch from 064a7e2 to 3c66f67 Mar 29, 2017
@emilio emilio force-pushed the emilio:expand branch from 3c66f67 to dade6e3 Mar 29, 2017
@SimonSapin
Copy link
Member

SimonSapin commented Mar 29, 2017

Oops, I didn’t realize you were working on the same and submitted #16183. I think mine goes a bit further, though. Sorry for the duplicate work!

@emilio
Copy link
Member Author

emilio commented Mar 29, 2017

No worries! Superseded by #16183.

@emilio emilio closed this Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.